Add f16 formatting and parsing
#127013
Draft
Add f16 formatting and parsing
#127013
+1,133
−605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
@rustbot label +rla-silenced |
rustbot
added
the
rla-silenced
|
@rustbot label +F-f16_and_f128 |
|
This will need #127510 |
|
☔ The latest upstream changes (presumably #127020) made this pull request unmergeable. Please resolve the merge conflicts. |
fbstj
reviewed
Jul 15, 2024
82 tasks
tgross35
force-pushed
the
f16-format-parse
branch
2 times, most recently
from
7c3f9c1
to
f3ebeb3
Compare
|
Update: I'm really just waiting on #128083 to bump stage0, managing |
|
☔ The latest upstream changes (presumably #128360) made this pull request unmergeable. Please resolve the merge conflicts. |
tgross35
force-pushed
the
f16-format-parse
branch
from
2eaa479
to
422c52e
Compare
Dylan-DPC
added
S-waiting-on-author
tgross35
force-pushed
the
f16-format-parse
branch
6 times, most recently
from
21ffabc
to
2098f01
Compare
rustbot
added
the
T-bootstrap
tgross35
force-pushed
the
f16-format-parse
branch
4 times, most recently
from
65fd050
to
404089f
Compare
These constants can be useful outside of their current module. Make them `pub(crate)` to allow for this.
Fix or elaborate existing float parsing documentation. This includes introducing a notation.
This module currently contains two decimal types, `Decimal` and `Number`. These names don't provide a whole lot of insight into what exactly they are, and `Number` is actually the one that is more like an expected `Decimal` type. In accordance with this, rename the existing `Decimal` to `DecimalSeq`. This highlights that it contains a sequence of decimal digits, rather than representing a floating point decimal as would be expected.
tgross35
force-pushed
the
f16-format-parse
branch
from
404089f
to
3636530
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
r? @ghost