Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .ignore file to make config.toml searchable in vscode #126876

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Add .ignore file to make config.toml searchable in vscode #126876

merged 1 commit into from
Jun 30, 2024

Conversation

WaffleLapkin
Copy link
Member

Based on this answer on Stack Overflow.

@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WaffleLapkin
Copy link
Member Author

???

@GrigorenkoPV
Copy link
Contributor

It wants copyright info for the file

+ reuse --include-submodules lint
# MISSING COPYRIGHT AND LICENSING INFORMATION

The following files have no copyright and licensing information:
* ../.ignore

[...]

Unfortunately, your project is not compliant with version 3.0 of the REUSE Specification :-(

The tool's website says that you should add the file to .gitignore if you want to exclude it from mandatory copyright: https://reuse.software/faq/#exclude-file

@rustbot rustbot added the A-meta Area: Issues & PRs about the rust-lang/rust repository itself label Jun 24, 2024
@tgross35
Copy link
Contributor

tgross35 commented Jun 24, 2024 •
edited
Loading

Works in Helix too 🎉 https://github.com/helix-editor/helix/blob/a982e5ce260e8191a2a24fa62e9e5bdf488bb5d4/book/src/editor.md?plain=1#L165

@Mark-Simulacrum
Copy link
Member

Seems plausible.

@bors r+

@bors
Copy link
Contributor

bors commented Jun 29, 2024

📌 Commit 879d143 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 30, 2024
@matthiaskrgr
Rollup merge of rust-lang#126876 - WaffleLapkin:unignoreconfigtoml, r…
d091d48 
…=Mark-Simulacrum

Add `.ignore` file to make `config.toml` searchable in vscode

Based on this answer on [Stack Overflow](https://stackoverflow.com/a/72059075).
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 30, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 30, 2024
@bors
Auto merge of rust-lang#127143 - matthiaskrgr:rollup-72eqqik, r=matth…
f9ae9f7 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#123778 (Improve autovectorization of to_lowercase / to_uppercase functions)
 - rust-lang#126705 (Updated docs on `#[panic_handler]` in `library/core/src/lib.rs`)
 - rust-lang#126876 (Add `.ignore` file to make `config.toml` searchable in vscode)
 - rust-lang#126906 (Small fixme in core now that split_first has no codegen issues)
 - rust-lang#127127 (rustdoc: update to pulldown-cmark 0.11)
 - rust-lang#127131 (Remove unused `rustc_trait_selection` dependencies)
 - rust-lang#127134 (Print `TypeId` as a `u128` for `Debug`)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 30, 2024
@matthiaskrgr
Rollup merge of rust-lang#126876 - WaffleLapkin:unignoreconfigtoml, r…
67d1328 
…=Mark-Simulacrum

Add `.ignore` file to make `config.toml` searchable in vscode

Based on this answer on [Stack Overflow](https://stackoverflow.com/a/72059075).
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 30, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 30, 2024
@bors
Auto merge of rust-lang#127148 - matthiaskrgr:rollup-1vumc1z, r=matth…
d833867 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#126705 (Updated docs on `#[panic_handler]` in `library/core/src/lib.rs`)
 - rust-lang#126876 (Add `.ignore` file to make `config.toml` searchable in vscode)
 - rust-lang#126906 (Small fixme in core now that split_first has no codegen issues)
 - rust-lang#127127 (rustdoc: update to pulldown-cmark 0.11)
 - rust-lang#127131 (Remove unused `rustc_trait_selection` dependencies)
 - rust-lang#127134 (Print `TypeId` as a `u128` for `Debug`)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 30, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 30, 2024
@bors
Auto merge of rust-lang#127156 - matthiaskrgr:rollup-jjfd464, r=matth…
afcf5de 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#126705 (Updated docs on `#[panic_handler]` in `library/core/src/lib.rs`)
 - rust-lang#126876 (Add `.ignore` file to make `config.toml` searchable in vscode)
 - rust-lang#126906 (Small fixme in core now that split_first has no codegen issues)
 - rust-lang#127023 (CI: rename Rust for Linux CI job)
 - rust-lang#127131 (Remove unused `rustc_trait_selection` dependencies)
 - rust-lang#127134 (Print `TypeId` as a `u128` for `Debug`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 30, 2024
@bors
Auto merge of rust-lang#127156 - matthiaskrgr:rollup-jjfd464, r=matth…
6c34855 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#126705 (Updated docs on `#[panic_handler]` in `library/core/src/lib.rs`)
 - rust-lang#126876 (Add `.ignore` file to make `config.toml` searchable in vscode)
 - rust-lang#126906 (Small fixme in core now that split_first has no codegen issues)
 - rust-lang#127023 (CI: rename Rust for Linux CI job)
 - rust-lang#127131 (Remove unused `rustc_trait_selection` dependencies)
 - rust-lang#127134 (Print `TypeId` as a `u128` for `Debug`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c7aee65 into rust-lang:master Jun 30, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jun 30, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 30, 2024
@rust-timer
Unrolled build for rust-lang#126876
b9eb18a 
Rollup merge of rust-lang#126876 - WaffleLapkin:unignoreconfigtoml, r=Mark-Simulacrum

Add `.ignore` file to make `config.toml` searchable in vscode

Based on this answer on [Stack Overflow](https://stackoverflow.com/a/72059075).
@WaffleLapkin WaffleLapkin deleted the unignoreconfigtoml branch June 30, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
7 participants
@WaffleLapkin @rustbot @rust-log-analyzer @GrigorenkoPV @tgross35 @Mark-Simulacrum @bors