Actually taint InferCtxt when a fulfillment error is emitted #126620

oli-obk · 2024-06-18T10:30:11Z

And avoid checking the global error counter

fixes #122044
fixes #123255
fixes #123276
fixes #125799

rustbot · 2024-06-18T10:30:20Z

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler/rustc_trait_selection/src/traits/error_reporting/type_err_ctxt_ext.rs

fee1-dead · 2024-06-18T15:12:45Z

Changes LGTM, will take another look after the outdated comment is updated/removed and CI green.

oli-obk · 2024-06-18T16:08:44Z

Moved the tests from the crashes test suite to ui tests

oli-obk · 2024-06-18T16:10:03Z

tests/crashes/122044.rs

This test was removed without replacement, because it covers the same ICE as tests/ui/const-generics/mistyped_const_in_pat.rs

fee1-dead · 2024-06-19T04:29:21Z

@rustbot author

fee1-dead

LGTM, had a potential improvement worth following up on

fee1-dead · 2024-06-19T07:57:17Z

tests/ui/const-generics/unify_with_nested_expr.stderr

 note: required by a bound in `bar`
-  --> $DIR/unify_with_nested_expr.rs:14:10
+  --> $DIR/unify_with_nested_expr.rs:12:8
   |
 LL | fn bar<const N: usize>()
-   |    --- required by a bound in this function
-LL | where
-LL |     [(); N + 1]:,
-   |          ^^^^^ required by this bound in `bar`
+   |        ^^^^^^^^^^^^^^ required by this bound in `bar`


I wonder if it makes sense to call this a bound? Is it pointing to the span of ConstArgHasType? At least on the language level this is just a const generic parameter and not a bound.

fee1-dead · 2024-06-19T08:16:32Z

@bors r+

bors · 2024-06-19T08:16:35Z

📌 Commit 1cb75dc has been approved by fee1-dead

It is now in the queue for this repository.

oli-obk · 2024-06-19T08:26:29Z

I adjusted the wording without doing a deeper refactoring

compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs

…cause of the bound that binds the parameter's type

oli-obk · 2024-06-19T14:59:19Z

@rustbot ready

fee1-dead · 2024-06-19T15:02:35Z

r=me when green

fee1-dead · 2024-06-19T15:58:27Z

@bors r+

bors · 2024-06-19T15:58:30Z

📌 Commit e4c9a8c has been approved by fee1-dead

It is now in the queue for this repository.

Actually taint InferCtxt when a fulfillment error is emitted And avoid checking the global error counter fixes rust-lang#122044 fixes rust-lang#123255 fixes rust-lang#123276 fixes rust-lang#125799

Rollup of 7 pull requests Successful merges: - rust-lang#124807 (Migrate `run-make/rustdoc-io-error` to `rmake.rs`) - rust-lang#126095 (Migrate `link-args-order`, `ls-metadata` and `lto-readonly-lib` `run-make` tests to `rmake`) - rust-lang#126308 (Ban `ArrayToPointer` and `MutToConstPointer` from runtime MIR) - rust-lang#126620 (Actually taint InferCtxt when a fulfillment error is emitted) - rust-lang#126629 (Migrate `run-make/compressed-debuginfo` to `rmake.rs`) - rust-lang#126644 (Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake) - rust-lang#126650 (Rename a bunch of things in the new solver and `rustc_type_ir`) r? `@ghost` `@rustbot` modify labels: rollup

Actually taint InferCtxt when a fulfillment error is emitted And avoid checking the global error counter fixes rust-lang#122044 fixes rust-lang#123255 fixes rust-lang#123276 fixes rust-lang#125799

Rollup of 9 pull requests Successful merges: - rust-lang#126095 (Migrate `link-args-order`, `ls-metadata` and `lto-readonly-lib` `run-make` tests to `rmake`) - rust-lang#126534 (Migrate `run-make/comment-section` to `rmake.rs`) - rust-lang#126620 (Actually taint InferCtxt when a fulfillment error is emitted) - rust-lang#126629 (Migrate `run-make/compressed-debuginfo` to `rmake.rs`) - rust-lang#126644 (Rewrite `extern-flag-rename-transitive`. `debugger-visualizer-dep-info`, `metadata-flag-frobs-symbols`, `extern-overrides-distribution` and `forced-unwind-terminate-pof` `run-make` tests to rmake) - rust-lang#126650 (Rename a bunch of things in the new solver and `rustc_type_ir`) - rust-lang#126698 (Migrate `unknown-mod-stdin`, `issue-68794-textrel-on-minimal-lib`, `raw-dylib-cross-compilation` and `used-cdylib-macos` `run-make` tests to rmake) - rust-lang#126703 (reword the hint::blackbox non-guarantees) - rust-lang#126708 (Minimize `can_begin_literal_maybe_minus` usage) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#126620 (Actually taint InferCtxt when a fulfillment error is emitted) - rust-lang#126649 (Fix `feature = "nightly"` in the new trait solver) - rust-lang#126652 (Clarify that anonymous consts still do introduce a new scope) - rust-lang#126703 (reword the hint::blackbox non-guarantees) - rust-lang#126708 (Minimize `can_begin_literal_maybe_minus` usage) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#126620 - oli-obk:taint_errors, r=fee1-dead Actually taint InferCtxt when a fulfillment error is emitted And avoid checking the global error counter fixes rust-lang#122044 fixes rust-lang#123255 fixes rust-lang#123276 fixes rust-lang#125799

rustbot assigned fee1-dead Jun 18, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 18, 2024

This comment has been minimized.

Sign in to view

oli-obk force-pushed the taint_errors branch from a9f2b2a to 1a6ec98 Compare June 18, 2024 13:49

This comment has been minimized.

Sign in to view

compiler-errors reviewed Jun 18, 2024

View reviewed changes

compiler/rustc_trait_selection/src/traits/error_reporting/type_err_ctxt_ext.rs Outdated Show resolved Hide resolved

Only check locally for reported errors

a183989

oli-obk force-pushed the taint_errors branch from 1a6ec98 to 6d139c7 Compare June 18, 2024 16:08

oli-obk commented Jun 18, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2024

oli-obk added 2 commits June 19, 2024 04:41

Taint infcx when reporting errors

3594a19

Remove a hack that isn't needed anymore

1cb75dc

oli-obk force-pushed the taint_errors branch from 6d139c7 to 1cb75dc Compare June 19, 2024 04:42

fee1-dead approved these changes Jun 19, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 19, 2024

fee1-dead reviewed Jun 19, 2024

View reviewed changes

compiler/rustc_trait_selection/src/traits/error_reporting/suggestions.rs Outdated Show resolved Hide resolved

fee1-dead added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 19, 2024

Const generic parameters aren't bounds, even if we end up erroring be…

e4c9a8c

…cause of the bound that binds the parameter's type

oli-obk force-pushed the taint_errors branch from 6bb93ca to e4c9a8c Compare June 19, 2024 14:58

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 19, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2024

jieyouxu mentioned this pull request Jun 19, 2024

Rollup of 7 pull requests #126710

Closed

jieyouxu mentioned this pull request Jun 19, 2024

Rollup of 9 pull requests #126714

Closed

jieyouxu mentioned this pull request Jun 19, 2024

Rollup of 9 pull requests #126716

Closed

matthiaskrgr mentioned this pull request Jun 20, 2024

Rollup of 5 pull requests #126726

Merged

bors merged commit e7be356 into rust-lang:master Jun 20, 2024
6 checks passed

rustbot added this to the 1.81.0 milestone Jun 20, 2024

matthiaskrgr mentioned this pull request Jul 25, 2024

ICE: unexpected const arg parent in type_of() #128176

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Actually taint InferCtxt when a fulfillment error is emitted #126620

Actually taint InferCtxt when a fulfillment error is emitted #126620

oli-obk commented Jun 18, 2024 •

edited

Loading

rustbot commented Jun 18, 2024

This comment has been minimized.

This comment has been minimized.

fee1-dead commented Jun 18, 2024

oli-obk commented Jun 18, 2024

oli-obk Jun 18, 2024

This comment has been minimized.

fee1-dead commented Jun 19, 2024

fee1-dead left a comment

fee1-dead Jun 19, 2024

fee1-dead commented Jun 19, 2024

bors commented Jun 19, 2024

oli-obk commented Jun 19, 2024

oli-obk commented Jun 19, 2024

fee1-dead commented Jun 19, 2024

fee1-dead commented Jun 19, 2024

bors commented Jun 19, 2024

Actually taint InferCtxt when a fulfillment error is emitted #126620

Actually taint InferCtxt when a fulfillment error is emitted #126620

Conversation

oli-obk commented Jun 18, 2024 • edited Loading

rustbot commented Jun 18, 2024

This comment has been minimized.

This comment has been minimized.

fee1-dead commented Jun 18, 2024

oli-obk commented Jun 18, 2024

oli-obk Jun 18, 2024

Choose a reason for hiding this comment

This comment has been minimized.

fee1-dead commented Jun 19, 2024

fee1-dead left a comment

Choose a reason for hiding this comment

fee1-dead Jun 19, 2024

Choose a reason for hiding this comment

fee1-dead commented Jun 19, 2024

bors commented Jun 19, 2024

oli-obk commented Jun 19, 2024

oli-obk commented Jun 19, 2024

fee1-dead commented Jun 19, 2024

fee1-dead commented Jun 19, 2024

bors commented Jun 19, 2024

oli-obk commented Jun 18, 2024 •

edited

Loading