-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote Mac Catalyst targets to Tier 2, and ship with rustup #126450
Conversation
rustbot has assigned @GuillaumeGomez. Use |
Failed to set assignee to
|
1 similar comment
Failed to set assignee to
|
This comment has been minimized.
This comment has been minimized.
r? compiler |
7b34126
to
64ec270
Compare
The MCP has been accepted, so: @rustbot ready |
Some changes occurred in src/doc/rustc/src/platform-support cc @Nilstrieb |
r? infra |
@bors r+ |
…rk-Simulacrum Promote Mac Catalyst targets to Tier 2, and ship with rustup Promote the Mac Catalyst targets `x86_64-apple-ios-macabi` and `aarch64-apple-ios-macabi` to Tier 2. Draft until [the MCP](rust-lang/compiler-team#761) finishes (see that for motivation). `@rustbot` author r? `@ghost`
64ec270
to
1a2b57b
Compare
These commits modify compiler targets. |
Still have to do some more digging, but it seems like the issue is that we don't pass the I'll try to fix this in the Linking https://github.com/leetal/ios-cmake to myself for later (might contain some of the relevant CMake configuration for this). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0b84a45
to
ee93b88
Compare
- aarch64-apple-ios-macabi - x86_64-apple-ios-macabi
This comment has been minimized.
This comment has been minimized.
ee93b88
to
3ed63dd
Compare
I've disabled the sanitizer runtimes on Mac Catalyst for now and opened #129069 for that, to get this moving forwards. I don't think it'll fail to merge again, I've tested it by replacing the |
@bors r+ rollup=iffy |
☀️ Test successful - checks-actions |
Finished benchmarking commit (6de928d): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 2.7%, secondary -4.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 751.389s -> 751.033s (-0.05%) |
obviously noise @rustbot label: +perf-regression-triaged |
Promote the Mac Catalyst targets
x86_64-apple-ios-macabi
andaarch64-apple-ios-macabi
to Tier 2, as per the MCP (see that for motivation and details).These targets are now also distributed with rustup, although without the sanitizer runtime, as that currently has trouble building, see #129069.