-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ignore-cross-compile directive from ui/macros/proc_macro #126254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Jun 11, 2024
@bors r+ rollup=iffy |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jun 11, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#126186 (Migrate `run-make/multiple-emits` to `rmake.rs`) - rust-lang#126236 (Delegation: fix ICE on recursive delegation) - rust-lang#126254 (Remove ignore-cross-compile directive from ui/macros/proc_macro) - rust-lang#126258 (Do not define opaque types when selecting impls) - rust-lang#126265 (interpret: ensure we check bool/char for validity when they are used in a cast) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2024
Rollup merge of rust-lang#126254 - ferrocene:lw-ignore-cross, r=pietroalbini Remove ignore-cross-compile directive from ui/macros/proc_macro All the other proc-macro tests don't have this, presumably this was forgotten when the restriction got lifted as it does test just fine r? `@pietroalbini`
tshepang
added a commit
to ferrocene/ferrocene
that referenced
this pull request
Jun 24, 2024
bors-ferrocene bot
added a commit
to ferrocene/ferrocene
that referenced
this pull request
Jun 24, 2024
728: Bump importlib-metadata from 7.2.0 to 7.2.1 in /ferrocene/doc/sphinx-shared-resources r=tshepang a=dependabot[bot] Bumps [importlib-metadata](https://github.com/python/importlib_metadata) from 7.2.0 to 7.2.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/python/importlib_metadata/blob/main/NEWS.rst">importlib-metadata's changelog</a>.</em></p> <blockquote> <h1>v7.2.1</h1> <h2>Bugfixes</h2> <ul> <li>When reading installed files from an egg, use <code>relative_to(walk_up=True)</code> to honor files installed outside of the installation root. (<a href="https://github.com/python/importlib_metadata/issues/455">#455</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/python/importlib_metadata/commit/b76931df96cb577bedbfac086d507a731a74b4b3"><code>b76931d</code></a> Finalize</li> <li><a href="https://github.com/python/importlib_metadata/commit/48d2a85c1c093a5f0b860be988449a2a1335ca63"><code>48d2a85</code></a> Merge pull request <a href="https://github.com/python/importlib_metadata/issues/482">#482</a> from dan-blanchard/fix-relative-to</li> <li><a href="https://github.com/python/importlib_metadata/commit/b94b42ef3103250a0f509f68170037199dc86583"><code>b94b42e</code></a> Add news fragment</li> <li><a href="https://github.com/python/importlib_metadata/commit/e4d1dcca7244c0d890c57eb24b3b8a6a76f4910e"><code>e4d1dcc</code></a> Remove additional method in SimplePath.</li> <li><a href="https://github.com/python/importlib_metadata/commit/07a2a4402fb39f03facea611fa9da8d9b927602e"><code>07a2a44</code></a> Revert "Fix mypy failure that has nothing to do with this PR"</li> <li><a href="https://github.com/python/importlib_metadata/commit/b815aee5352ed728f6f90ba7362f3dddf46ab418"><code>b815aee</code></a> Mark compat code as uncovered.</li> <li><a href="https://github.com/python/importlib_metadata/commit/52ce982c34349bd5aeabd771a475109aef9aa4a8"><code>52ce982</code></a> Merge branch 'main' into fix-relative-to</li> <li><a href="https://github.com/python/importlib_metadata/commit/1584b96f50317f7cbf55192706a9a1c4ef869a3b"><code>1584b96</code></a> Update wrapper to rely on 'relative_to(walk_up=True)' on Python 3.12 and comp...</li> <li><a href="https://github.com/python/importlib_metadata/commit/08d74cc165094bda158e108747fa39ae10674bbf"><code>08d74cc</code></a> Move _relative_to compatibility to a compat module.</li> <li><a href="https://github.com/python/importlib_metadata/commit/e8998d977ce8867016f25e59728f1d9501ae4282"><code>e8998d9</code></a> Merge <a href="https://github.com/jaraco/skeleton">https://github.com/jaraco/skeleton</a></li> <li>Additional commits viewable in <a href="https://github.com/python/importlib_metadata/compare/v7.2.0...v7.2.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=importlib-metadata&package-manager=pip&previous-version=7.2.0&new-version=7.2.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 729: now also available on non-host platforms r=Veykril a=tshepang See rust-lang/rust#126254 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tshepang Mbambo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the other proc-macro tests don't have this, presumably this was forgotten when the restriction got lifted as it does test just fine
r? @pietroalbini