Change how runmake v2 tests are executed

[Kobzol]

This PR makes execution of v2 runmake tests more sane, by executing each test in a temporary directory by default, rather than running it inside tests/run-make. This will have.. a lot of conflicts.

Fixes: #126080
Closes #125726, because it removes tmp_dir, lol.

r? @jieyouxu

try-job: x86_64-msvc

[rustbot]

Some changes occurred in src/tools/compiletest

cc @jieyouxu

The run-make-support library was changed

cc @jieyouxu

Some changes occurred in run-make tests.

cc @jieyouxu

[bors]

☔ The latest upstream changes (presumably #126104) made this pull request unmergeable. Please resolve the merge conflicts.

[Kobzol]

This is now ready for a review (best reviewed commit-by-commit, of course).

@rustbot ready

[jieyouxu]

Love the changes, takes away a lot of visual noise in the test.

[jieyouxu]

Changes look good, only have minor non-blocking nits, feel free to r=me with or without addressing them. I don't know if the cwd() nits are fixed by the small refactoring PR, the review UI makes it a bit hard to tell.

[Kobzol]

Fixed the nits (apart from the command_output, because that requires a bit more work across run-make-support, we talked about this before - adding some custom Output struct for easy stdout/stderr asserting etc.). I also included one more commit based on the rust lib path cleanup, as we no longer need two functions for name/path of static/dynamic/rlib libraries.

Let me know if the last two commits are OK for you.

@bors rollup=never

[jieyouxu]

Looks good, r=me after CI is green

[Kobzol]

@bors r=jieyouxu

[bors]

📌 Commit ca583cb has been approved by jieyouxu

It is now in the queue for this repository.

[bors]

⌛ Testing commit b10a404 with merge 2c5647e...

[Noratrieb]

@bors r-
bors what the hell are you doing are you are testing #125966 (comment) already

[Noratrieb]

oh this is supposed to be a try build... the queue disagrees :)

[BoxyUwU]

@pietroalbini commanded me to:
@bors retry

[Noratrieb]

it's not in the queue, so
@rustbot author

[bors]

☀️ Try build successful - checks-actions
Build commit: 2c5647e (2c5647e646f650e4fb235da3ec3f715a9a88e047)

[Kobzol]

@bors r=jieyouxu

[bors]

📌 Commit b10a404 has been approved by jieyouxu

It is now in the queue for this repository.

[bors]

⌛ Testing commit b10a404 with merge cfdb617...

[bors]

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing cfdb617 to master...

[rust-timer]

Finished benchmarking commit (cfdb617): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.4%	[2.4%, 2.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.4%	[2.4%, 2.4%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: missing data
Artifact size: 319.76 MiB -> 319.74 MiB (-0.00%)