-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change how runmake v2 tests are executed #126097
Conversation
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #126104) made this pull request unmergeable. Please resolve the merge conflicts. |
And also remove some environment variables passed to compilation of `rmake.rs`.
ce5d1e2
to
d86c981
Compare
This is now ready for a review (best reviewed commit-by-commit, of course). @rustbot ready |
This comment has been minimized.
This comment has been minimized.
f523b18
to
4b0842f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the changes, takes away a lot of visual noise in the test.
Changes look good, only have minor non-blocking nits, feel free to r=me with or without addressing them. I don't know if the |
Fixed the nits (apart from the Let me know if the last two commits are OK for you. @bors rollup=never |
Looks good, r=me after CI is green |
@bors r=jieyouxu |
3ddafbc
to
b10a404
Compare
Change how runmake v2 tests are executed This PR makes execution of v2 runmake tests more sane, by executing each test in a temporary directory by default, rather than running it inside `tests/run-make`. This will have.. a lot of conflicts. Fixes: rust-lang#126080 Closes rust-lang#125726, because it removes `tmp_dir`, lol. r? `@jieyouxu` try-job: x86_64-msvc
@bors r- |
oh this is supposed to be a try build... the queue disagrees :) |
@pietroalbini commanded me to: |
it's not in the queue, so |
☀️ Try build successful - checks-actions |
@bors r=jieyouxu |
☀️ Test successful - checks-actions |
Finished benchmarking commit (cfdb617): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 2.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: missing data |
This PR makes execution of v2 runmake tests more sane, by executing each test in a temporary directory by default, rather than running it inside
tests/run-make
. This will have.. a lot of conflicts.Fixes: #126080
Closes #125726, because it removes
tmp_dir
, lol.r? @jieyouxu
try-job: x86_64-msvc