Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tests #125256

Closed
wants to merge 1 commit into from
Closed

Move tests #125256

wants to merge 1 commit into from

Conversation

c410-f3r
Copy link
Contributor

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 18, 2024
@jieyouxu
Copy link
Member

Thanks!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 18, 2024

📌 Commit bcea677 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2024
workingjubilee
workingjubilee requested changes May 18, 2024
View reviewed changes
src/tools/tidy/src/issues.txt
@@ -3618,6 +3615,7 @@ ui/recursion/issue-83150.rs
ui/recursion/issue-86784.rs
ui/recursion/issue-95134.rs
ui/recursion_limit/issue-105700.rs
ui/recursion_limit/issue-37311-type-length-limit/issue-37311.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please instead rename this and the associated .stderr files to

  • tests/ui/recursion_limit/type-length-limit-issue-37311.rs
  • tests/ui/recursion_limit/type-length-limit-issue-37311.stderr
  • tests/ui/recursion_limit/type-length-limit-issue-37311.polonius.stderr

My reasoning is that there doesn't seem to be much merit in nesting these inside a folder that has the same name, and that this would allow eliminating these entries from this list.

src/tools/tidy/src/issues.txt
Comment on lines +3851 to +3852
ui/static/issue-3668-non-constant-value-in-constant/issue-3668-2.rs
ui/static/issue-3668-non-constant-value-in-constant/issue-3668.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same request but

  • tests/ui/static/non-constant-value-in-constant-issue-3668.rs
  • tests/ui/static/non-constant-value-in-constant-issue-3668-2.rs

and so on.

src/tools/tidy/src/issues.txt
Comment on lines +1142 to +1144
ui/generics/issue-5997-outer-generic-parameter/issue-5997-enum.rs
ui/generics/issue-5997-outer-generic-parameter/issue-5997-struct.rs
ui/generics/issue-5997-outer-generic-parameter/issue-5997.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same request.

src/tools/tidy/src/issues.txt
Comment on lines +856 to +857
ui/cross-crate/issue-38875/auxiliary/issue-38875-b.rs
ui/cross-crate/issue-38875/issue-38875.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original issue was named "constant evaluation error" points to nothing when crossing the crate boundary, the solution PR was implement lazy-loading of crate's sources, could you rename this for that? Perhaps the root one should be

  • tests/ui/cross-crate/lazy-load-externs/const-issue-38875.rs

@jieyouxu
Copy link
Member

@bors r- (for renaming requests)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 18, 2024
@bors
Copy link
Contributor

bors commented May 21, 2024

☔ The latest upstream changes (presumably #125379) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC
Copy link
Member

@c410-f3r any updates on this? thanks

@c410-f3r
Copy link
Contributor Author

This PR is outdated so I am going to close it.

@c410-f3r c410-f3r closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee requested changes

Assignees

@petrochenkov petrochenkov

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@c410-f3r @jieyouxu @bors @Dylan-DPC @workingjubilee @petrochenkov @rustbot