Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] backports #125183

Merged
merged 8 commits into from
May 17, 2024
Merged

[beta] backports #125183

merged 8 commits into from
May 17, 2024

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented May 16, 2024 •
edited
Loading

r? cuviper

estebank and others added 7 commits May 16, 2024 09:06
@estebank @cuviper
Do not ICE on foreign malformed diagnostic::on_unimplemented
6af338d 
Fix rust-lang#124651.

(cherry picked from commit 4847f22)
@estebank @cuviper
Add test for rust-lang#124651
4054780 
(cherry picked from commit 758e459)
@compiler-errors @cuviper
Add more ICEs due to malformed diagnostic::on_unimplemented
5d77c79 
(cherry picked from commit a8f2e33)
@compiler-errors @cuviper
Fix ICEs in diagnostic::on_unimplemented
716c563 
(cherry picked from commit 7dbdbaa)
@notriddle @cuviper
rustdoc: use stability, instead of features, to decide what to show
75e17c9 
To decide if internal items should be inlined in a doc page,
check if the crate is itself internal, rather than if it has
the rustc_private feature flag. The standard library uses
internal items, but is not itself internal and should not show
internal items on its docs pages.

(cherry picked from commit 6d6f67a)
@compiler-errors @cuviper
Don't do post-method-probe error reporting steps if we're in a sugges…
37301f5 
…tion

(cherry picked from commit 2e4c90c)
@compiler-errors @cuviper
Add test to make sure suggestions are still quick
d4e19af 
(cherry picked from commit 8f97a25)
@rustbot
Copy link
Collaborator

rustbot commented May 16, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 16, 2024
@cuviper cuviper mentioned this pull request May 16, 2024
Closed
@cuviper
Copy link
Member Author

cuviper commented May 16, 2024

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented May 16, 2024

📌 Commit cfae8b2 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2024
@bors
Copy link
Contributor

bors commented May 17, 2024

⌛ Testing commit cfae8b2 with merge 0436bf1...

@bors
Copy link
Contributor

bors commented May 17, 2024

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 0436bf1 to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 17, 2024
@bors bors merged commit 0436bf1 into rust-lang:beta May 17, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone May 17, 2024
@workingjubilee workingjubilee mentioned this pull request May 29, 2024
Closed
@Urgau Urgau mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
7 participants
@cuviper @rustbot @bors @estebank @compiler-errors @notriddle @wesleywiser