Rollup of 5 pull requests #125179
Merged
Rollup of 5 pull requests #125179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These types are currently rejected for `as` casts by the compiler. Remove this incorrect check and add codegen tests for all conversions involving these types.
…ligation causes inference side-effects
Don't ICE because recomputing overflow goals during find_best_leaf_obligation causes inference side-effects See the comments for more info. Reprocessing overflowed obligations may cause *other* goals to go from ambig -> pass/fail, causing an ICE. This suppresses that error, but makes all the overflow obligations messages back to their root obl. That kinda sucks, but 🤷 Fixes rust-lang#124834 Fixes rust-lang#124845 r? lcnr
Update linker-plugin-lto.md to include LLVM 18 I did this manually not via provided script.
…Gomez rustdoc-json-types: Document `Id` Inspired by finding [someone looking into the internals of an id](rust-lang#91609 (comment)), I realized we only document the fact that these are opaque on [the rfc](https://rust-lang.github.io/rfcs/2963-rustdoc-json.html#id). r? `@GuillaumeGomez`
…=lcnr Uplift `FnSig` into `rustc_type_ir` (redux) Since the last one got so messed up with `try` build. rust-lang#125157 (comment) r? lcnr
…mpiler-errors Fix assertion when attempting to convert `f16` and `f128` with `as` These types are currently rejected for `as` casts by the compiler. Remove this incorrect check and add codegen tests for all conversions involving these types.
rustbot
added
A-rustdoc-json
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 4a78c00e22 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced May 16, 2024
|
Finished benchmarking commit (97bf25c): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 679.603s -> 677.731s (-0.28%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Id#125130 (rustdoc-json-types: DocumentId)FnSigintorustc_type_ir(redux) #125170 (UpliftFnSigintorustc_type_ir(redux))f16andf128withas#125172 (Fix assertion when attempting to convertf16andf128withas)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup