Fix ICE while casting a type with error

[gurry]

Fixes #124848

The ICE originates here:

rust/compiler/rustc_hir_typeck/src/cast.rs

Line 143 in f9a3fd9

self.dcx().span_bug(span, format!("`{t:?}` should be sized but is not?"));

The underlying cause is that a type with error, MyType was involved in a cast. During cast checks the below method pointer_kind was called:

rust/compiler/rustc_hir_typeck/src/cast.rs

Lines 87 to 91 in f9a3fd9

	fn pointer_kind(
	&self,
	t: Ty<'tcx>,
	span: Span,
	) -> Result<Option<PointerKind<'tcx>>, ErrorGuaranteed> {

Thanks to the changes in PR #123491, type_is_sized_modulo_regions in pointer_kind returned false which caused control to reach the span_bug here:

rust/compiler/rustc_hir_typeck/src/cast.rs

Line 143 in f9a3fd9

self.dcx().span_bug(span, format!("`{t:?}` should be sized but is not?"));

resulting in an ICE.

This PR fixes the issue by changing the span_bug to a span_delayed_bug.

[rustbot]

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[Nadrieril]

@bors r+

[bors]

📌 Commit fb619ec has been approved by Nadrieril

It is now in the queue for this repository.