Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace another Option<Span> by DUMMY_SP #124842

Merged
merged 1 commit into from
May 7, 2024
Merged

replace another Option<Span> by DUMMY_SP #124842

merged 1 commit into from
May 7, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented May 7, 2024

This was missed in #122480.

@rustbot
Copy link
Collaborator

rustbot commented May 7, 2024

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 7, 2024
@compiler-errors
Copy link
Member

r? compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented May 7, 2024

📌 Commit 1d87efc has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned Nadrieril May 7, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request May 7, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 7, 2024
@bors
Auto merge of rust-lang#124849 - matthiaskrgr:rollup-68humsk, r=matth…
b923ea4 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#124738 (rustdoc: dedup search form HTML)
 - rust-lang#124827 (generalize hr alias: avoid unconstrainable infer vars)
 - rust-lang#124832 (narrow down visibilities in `rustc_parse::lexer`)
 - rust-lang#124842 (replace another Option<Span> by DUMMY_SP)
 - rust-lang#124846 (Don't ICE when we cannot eval a const to a valtree in the new solver)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a29a7d1 into rust-lang:master May 7, 2024
6 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 7, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 7, 2024
@rust-timer
Unrolled build for rust-lang#124842
7b0e9ae 
Rollup merge of rust-lang#124842 - RalfJung:option-span, r=compiler-errors

replace another Option<Span> by DUMMY_SP

This was missed in rust-lang#122480.
@RalfJung RalfJung deleted the option-span branch May 8, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @rustbot @compiler-errors @bors @Nadrieril