Migrate run-make/rustdoc-error-lines to new rmake.rs
#124753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
migrate-rustdoc-determinism
branch
2 times, most recently
from
dd53da9 to
458bfb4
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
migrate-rustdoc-determinism
branch
from
458bfb4 to
bb474aa
Compare
|
CI passed this time. :) |
jieyouxu
approved these changes
May 5, 2024
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
fmease
added a commit
to fmease/rust
that referenced
this pull request
May 5, 2024
…erminism, r=jieyouxu Migrate `run-make/rustdoc-error-lines` to new `rmake.rs` Part of rust-lang#121876. There was a weird naming inconsistency with `input`/`output`. A few tests write `.arg("-o").arg(path)` and the `output` method was actually the command output. So instead, I renamed the original `output` into `command_output` so that I could create the `output` method with the expected effect (and updated the tests to use it too). EDIT: The first two commits come from rust-lang#124711. Some weird things happened recently pparently. ^^' r? `@jieyouxu`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#124742 (Add `rustfmt` cfg to well known cfgs list) - rust-lang#124747 (Support Result<T, E> across FFI when niche optimization can be used (v2)) - rust-lang#124753 (Migrate `run-make/rustdoc-error-lines` to new `rmake.rs`) - rust-lang#124765 ([rustdoc] Fix bad color for setting cog in ayu theme) - rust-lang#124768 ([resubmission] Meta: Enable the brand new triagebot transfer command) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 6, 2024
…erminism, r=jieyouxu Migrate `run-make/rustdoc-error-lines` to new `rmake.rs` Part of rust-lang#121876. There was a weird naming inconsistency with `input`/`output`. A few tests write `.arg("-o").arg(path)` and the `output` method was actually the command output. So instead, I renamed the original `output` into `command_output` so that I could create the `output` method with the expected effect (and updated the tests to use it too). EDIT: The first two commits come from rust-lang#124711. Some weird things happened recently pparently. ^^' r? ``@jieyouxu``
bors
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
migrate-rustdoc-determinism
branch
from
bb474aa to
34fe217
Compare
|
Thanks for the notification, fixed it. @bors r=jieyouxu rollup |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (25e3949): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 676.654s -> 676.836s (0.03%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #121876.
There was a weird naming inconsistency with
input/output. A few tests write.arg("-o").arg(path)and theoutputmethod was actually the command output. So instead, I renamed the originaloutputintocommand_outputso that I could create theoutputmethod with the expected effect (and updated the tests to use it too).EDIT: The first two commits come from #124711. Some weird things happened recently pparently. ^^'
r? @jieyouxu