Add translation support by mdbook-i18n-helpers to bootstrap #124731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
dalance
force-pushed
the
add_translation_support
branch
from
de8a206
to
aa219a1
Compare
This comment has been minimized.
This comment has been minimized.
dalance
force-pushed
the
add_translation_support
branch
from
aa219a1
to
0177a37
Compare
This comment has been minimized.
This comment has been minimized.
This was referenced May 7, 2024
|
r? @ehuss since you I think(?) maintain mdbook so might be more familiar with problems we might hit. This seems broadly OK to me though. cc @davidtwco / @Manishearth (?) as well for i18n efforts more broadly, mostly just as FYI (not sure if there's anything in particular here to take a look at) |
|
Seems fine overall. It looks like it adds about 15MB to the overall doc size, which should be fine for now (the docs are currently about 724MB), but we may need to think about this more carefully if there is a significant proliferation of translations in the future. It looks like there are also some broken links here, though. |
This was referenced May 14, 2024
|
The broken links was fixed at the upstream repo. It will be reflected at the next submodule update. |
dalance
force-pushed
the
add_translation_support
branch
from
0177a37
to
366dd21
Compare
This comment has been minimized.
This comment has been minimized.
dalance
force-pushed
the
add_translation_support
branch
from
366dd21
to
b0203c0
Compare
This comment has been minimized.
This comment has been minimized.
dalance
force-pushed
the
add_translation_support
branch
from
b0203c0
to
08eeeb8
Compare
This comment has been minimized.
This comment has been minimized.
dalance
force-pushed
the
add_translation_support
branch
from
08eeeb8
to
9e51740
Compare
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
|
@ehuss I changed the dependency to the original mdbook-i18n-helpers and this PR became ready for review. |
dalance
force-pushed
the
add_translation_support
branch
from
9e51740
to
9d1ec7e
Compare
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 5, 2024
…=ehuss Add translation support by mdbook-i18n-helpers to bootstrap This PR add translation support by [mdbook-i18n-helpers](https://github.com/google/mdbook-i18n-helpers) to bootstrap. This is draft PR because there is the dependency to my forked mdbook-i18n-helpers. If this PR is acceptable, I'll send a PR to the original mdbook-i18n-helpers and remove draft after changing the dependency to the original. Closes rust-lang#124641
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 6, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#124731 (Add translation support by mdbook-i18n-helpers to bootstrap) - rust-lang#125168 (Match ergonomics 2024: align implementation with RFC) - rust-lang#125925 (Don't trigger `unsafe_op_in_unsafe_fn` for deprecated safe fns) - rust-lang#125966 (Implement `os_string_pathbuf_leak`) - rust-lang#125987 (When `derive`ing, account for HRTB on `BareFn` fields) - rust-lang#126045 (check_expr_struct_fields: taint context with errors if struct definit…) - rust-lang#126048 (Fix typos in cargo-specifics.md) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 6, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#124731 (Add translation support by mdbook-i18n-helpers to bootstrap) - rust-lang#125168 (Match ergonomics 2024: align implementation with RFC) - rust-lang#125925 (Don't trigger `unsafe_op_in_unsafe_fn` for deprecated safe fns) - rust-lang#125987 (When `derive`ing, account for HRTB on `BareFn` fields) - rust-lang#126045 (check_expr_struct_fields: taint context with errors if struct definit…) - rust-lang#126048 (Fix typos in cargo-specifics.md) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 6, 2024
Rollup merge of rust-lang#124731 - dalance:add_translation_support, r=ehuss Add translation support by mdbook-i18n-helpers to bootstrap This PR add translation support by [mdbook-i18n-helpers](https://github.com/google/mdbook-i18n-helpers) to bootstrap. This is draft PR because there is the dependency to my forked mdbook-i18n-helpers. If this PR is acceptable, I'll send a PR to the original mdbook-i18n-helpers and remove draft after changing the dependency to the original. Closes rust-lang#124641
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add translation support by mdbook-i18n-helpers to bootstrap.
This is draft PR because there is the dependency to my forked mdbook-i18n-helpers.
If this PR is acceptable, I'll send a PR to the original mdbook-i18n-helpers and remove draft after changing the dependency to the original.
Closes #124641