Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port print-cfg run-make test to Rust-based rmake.rs #124473

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Apr 28, 2024

This PR port the print-cfg run-make test to Rust-based rmake.rs tests.

The actual test is now split in two:

  • the first part for the --print=cfg part
  • and the second part for the =PATH part of --print

Part of #121876.

r? @jieyouxu

@rustbot rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Apr 28, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 28, 2024

Some changes occurred in run-make tests.

cc @jieyouxu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 28, 2024
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some nitpicks.

tests/run-make/print-cfg/rmake.rs Outdated Show resolved Hide resolved
tests/run-make/print-to-output/rmake.rs Outdated Show resolved Hide resolved
tests/run-make/print-to-output/rmake.rs Outdated Show resolved Hide resolved
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@bors r+ rollup

@jieyouxu
Copy link
Member

Err I guess bors doesn't read from review comment?

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 28, 2024

📌 Commit 006c94c has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2024
…iaskrgr

Rollup of 2 pull requests

Successful merges:

 - rust-lang#123734 (Inline more svg images into CSS)
 - rust-lang#124473 (Port `print-cfg` run-make test to Rust-based rmake.rs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6edb721 into rust-lang:master Apr 28, 2024
10 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2024
Rollup merge of rust-lang#124473 - Urgau:port-print-cfg, r=jieyouxu

Port `print-cfg` run-make test to Rust-based rmake.rs

This PR port the `print-cfg` run-make test to Rust-based rmake.rs tests.

The actual test is now split in two:
 - the first part for the `--print=cfg` part
 - and the second part for the `=PATH` part of `--print`

Part of rust-lang#121876.

r? `@jieyouxu`
@rustbot rustbot added this to the 1.80.0 milestone Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants