-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port print-cfg
run-make test to Rust-based rmake.rs
#124473
Conversation
Some changes occurred in run-make tests. cc @jieyouxu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just some nitpicks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
@bors r+ rollup
Err I guess bors doesn't read from review comment? @bors r+ rollup |
…iaskrgr Rollup of 2 pull requests Successful merges: - rust-lang#123734 (Inline more svg images into CSS) - rust-lang#124473 (Port `print-cfg` run-make test to Rust-based rmake.rs) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#124473 - Urgau:port-print-cfg, r=jieyouxu Port `print-cfg` run-make test to Rust-based rmake.rs This PR port the `print-cfg` run-make test to Rust-based rmake.rs tests. The actual test is now split in two: - the first part for the `--print=cfg` part - and the second part for the `=PATH` part of `--print` Part of rust-lang#121876. r? `@jieyouxu`
This PR port the
print-cfg
run-make test to Rust-based rmake.rs tests.The actual test is now split in two:
--print=cfg
part=PATH
part of--print
Part of #121876.
r? @jieyouxu