Add backticks #12441
Merged
Add backticks #12441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
Feb 22, 2014
Not all of those messages are covered by tests. I am not sure how to trigger them and where to put those tests. Also some message patterns in the existing tests are not complete. For example, i find `error: mismatched types: expected "i32" but found "char" (expected i32 but found char)` a bit repetitive, but as i can see there is no test covering that.
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
fix: rust-lang#12441 False-positive type-mismatch error with generic future I think the reason is same with rust-lang#11815. add ```Sized``` bound for ```AsyncBlockTypeImplTrait```.
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 21, 2024
…=dswij [`else_if_without_else`]: Fix duplicate diagnostics Relates to: rust-lang#12379 changelog: Fix duplicate lint diagnostic emission from [`else_if_without_else`]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all of those messages are covered by tests. I am not sure how to trigger them and where to put those tests.
Also some message patterns in the existing tests are not complete.
For example, i find
error: mismatched types: expected "i32" but found "char" (expected i32 but found char)a bit repetitive, but as i can see there is no test covering that.