resolve: Remove two cases of misleading macro call visiting #124341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Macro calls are ephemeral, they should not add anything to the definition tree, even if their AST could contains something with identity. Thankfully, macro call AST cannot contain anything like that, so these walks are just noops. In majority of other places in def_collector / build_reduced_graph they are already not visited. (Also, a minor match reformatting is included.)
rustbot
added
S-waiting-on-review
compiler-errors
approved these changes
Apr 26, 2024
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 26, 2024
…r-errors resolve: Remove two cases of misleading macro call visiting Macro calls are ephemeral, they should not add anything to the definition tree, even if their AST could contains something with identity. Thankfully, macro call AST cannot contain anything like that, so these walks are just noops. In majority of other places in def_collector / build_reduced_graph they are already not visited. (Also, a minor match reformatting is included.)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 26, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#124341 (resolve: Remove two cases of misleading macro call visiting) - rust-lang#124383 (Port run-make `--print=native-static-libs` to rmake.rs) - rust-lang#124391 (`rustc_builtin_macros` cleanups) - rust-lang#124408 (crashes: add more tests) - rust-lang#124410 (PathBuf: replace transmuting by accessor functions) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#124341 (resolve: Remove two cases of misleading macro call visiting) - rust-lang#124383 (Port run-make `--print=native-static-libs` to rmake.rs) - rust-lang#124391 (`rustc_builtin_macros` cleanups) - rust-lang#124408 (crashes: add more tests) - rust-lang#124410 (PathBuf: replace transmuting by accessor functions) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2024
Rollup merge of rust-lang#124341 - petrochenkov:nomacvisit, r=compiler-errors resolve: Remove two cases of misleading macro call visiting Macro calls are ephemeral, they should not add anything to the definition tree, even if their AST could contains something with identity. Thankfully, macro call AST cannot contain anything like that, so these walks are just noops. In majority of other places in def_collector / build_reduced_graph they are already not visited. (Also, a minor match reformatting is included.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macro calls are ephemeral, they should not add anything to the definition tree, even if their AST could contains something with identity.
Thankfully, macro call AST cannot contain anything like that, so these walks are just noops.
In majority of other places in def_collector / build_reduced_graph they are already not visited.
(Also, a minor match reformatting is included.)