Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diagnostic for unknown --print request #124333

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Improve diagnostic for unknown --print request #124333

merged 1 commit into from
Apr 25, 2024

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Apr 24, 2024

This PR improves the diagnostic when encountering a unknown --print request.

It also moves the run-make test to a simple UI test.

@rustbot
Copy link
Collaborator

rustbot commented Apr 24, 2024

r? @pnkfelix

rustbot has assigned @pnkfelix.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 24, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 24, 2024

Some changes occurred in run-make tests.

cc @jieyouxu

fmease
fmease approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@fmease fmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmease
Copy link
Member

fmease commented Apr 24, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 24, 2024

📌 Commit 153b1f0 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2024
fmease
fmease reviewed Apr 24, 2024
View reviewed changes
Copy link
Member

@fmease fmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'm surprised we don't need //@ error-pattern here

@Urgau
Copy link
Member Author

Urgau commented Apr 24, 2024

Actually, I'm surprised we don't need //@ error-pattern here

error-pattern is for matching a regex in the entire output, it's useful when the output is non-deterministic or when unrelated output are present; neither of which are the case here, so no need for error-pattern, it also wasn't the case before (it was a plain old diff)

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 24, 2024
@matthiaskrgr
Rollup merge of rust-lang#124333 - Urgau:better-bad-print, r=fmease
640d02b 
Improve diagnostic for unknown `--print` request

This PR improves the diagnostic when encountering a unknown `--print` request.

It also moves the run-make test to a simple UI test.
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 24, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 24, 2024
@matthiaskrgr
Rollup merge of rust-lang#124333 - Urgau:better-bad-print, r=fmease
479cd75 
Improve diagnostic for unknown `--print` request

This PR improves the diagnostic when encountering a unknown `--print` request.

It also moves the run-make test to a simple UI test.
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 24, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2024
@bors
Auto merge of rust-lang#124344 - matthiaskrgr:rollup-de726d8, r=matth…
40a7601 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#124322 (chore: fix some typos in comments)
 - rust-lang#124326 (tests: remove few ignore-stage2)
 - rust-lang#124333 (Improve diagnostic for unknown `--print` request)
 - rust-lang#124334 (Strengthen tracking issue policy with consequences)
 - rust-lang#124335 (Stabilize `std::path::absolute`)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 24, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2024
@bors
Auto merge of rust-lang#124354 - matthiaskrgr:rollup-xsdnixm, r=matth…
dfc400e 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#124322 (chore: fix some typos in comments)
 - rust-lang#124333 (Improve diagnostic for unknown `--print` request)
 - rust-lang#124334 (Strengthen tracking issue policy with consequences)
 - rust-lang#124335 (Stabilize `std::path::absolute`)
 - rust-lang#124351 (fix typo in binary_heap docs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f46b828 into rust-lang:master Apr 25, 2024
10 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 25, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 25, 2024
@rust-timer
Unrolled build for rust-lang#124333
b5bf30d 
Rollup merge of rust-lang#124333 - Urgau:better-bad-print, r=fmease

Improve diagnostic for unknown `--print` request

This PR improves the diagnostic when encountering a unknown `--print` request.

It also moves the run-make test to a simple UI test.
@Urgau Urgau deleted the better-bad-print branch April 25, 2024 05:54
@Kobzol Kobzol mentioned this pull request Aug 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease approved these changes

Assignees

@pnkfelix pnkfelix

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Urgau @rustbot @fmease @bors @pnkfelix