Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove push_trait_bound_inner #124288

Merged
merged 1 commit into from
Apr 23, 2024
Merged

remove push_trait_bound_inner #124288

merged 1 commit into from
Apr 23, 2024

Conversation

fee1-dead
Copy link
Member

Don't see a use for it.

@rustbot
Copy link
Collaborator

rustbot commented Apr 23, 2024

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 23, 2024
@fmease
Copy link
Member

fmease commented Apr 23, 2024 •
edited
Loading

Yup, that's a leftover from the bound duplication code (~const Tr -> Tr<false> + Tr<true>) that we removed again (not fully as can be seen here).

@fmease
Copy link
Member

fmease commented Apr 23, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 23, 2024

📌 Commit 7f3c831 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 23, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 23, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 23, 2024
@bors
Auto merge of rust-lang#124289 - matthiaskrgr:rollup-oxw52jy, r=matth…
ad07aa1 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#123050 (panic_str only exists for the migration to 2021 panic macros)
 - rust-lang#124067 (weak lang items are not allowed to be #[track_caller])
 - rust-lang#124099 (Disallow ambiguous attributes on expressions)
 - rust-lang#124284 (parser: remove unused(no reads) max_angle_bracket_count field)
 - rust-lang#124288 (remove `push_trait_bound_inner`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 802f629 into rust-lang:master Apr 23, 2024
12 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 23, 2024
@rust-timer
Unrolled build for rust-lang#124288
d321d83 
Rollup merge of rust-lang#124288 - fee1-dead-contrib:rm_inner, r=fmease

remove `push_trait_bound_inner`

Don't see a use for it.
@rustbot rustbot added this to the 1.79.0 milestone Apr 23, 2024
@fee1-dead fee1-dead deleted the rm_inner branch April 30, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease approved these changes

Assignees

@fmease fmease

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fee1-dead @rustbot @fmease @bors