Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove an unused type from the reentrant lock tests #124266

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

RalfJung
Copy link
Member

At least it seems unused. This was added back in 45aa6c8 together with a test related to poisoning; when the test got removed, it seems like it was forgotten to also remove this type.

@rustbot
Copy link
Collaborator

rustbot commented Apr 22, 2024

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 22, 2024
@rust-log-analyzer

This comment has been minimized.

@joboet
Copy link
Member

joboet commented Apr 22, 2024

Yeah, this seems like an oversight...
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 22, 2024

📌 Commit df437a2 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 23, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#123680 (Deny gen keyword in `edition_2024_compat` lints)
 - rust-lang#124057 (Fix ICE when ADT tail has type error)
 - rust-lang#124168 (Use `DefiningOpaqueTypes::Yes` in rustdoc, where the `InferCtxt` is guaranteed to have no opaque types it can define)
 - rust-lang#124197 (Move duplicated code in functions in `tests/rustdoc-gui/notable-trait.goml`)
 - rust-lang#124200 (Improve handling of expr->field errors)
 - rust-lang#124220 (Miri: detect wrong vtables in wide pointers)
 - rust-lang#124266 (remove an unused type from the reentrant lock tests)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 819b4d5 into rust-lang:master Apr 23, 2024
12 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 23, 2024
Rollup merge of rust-lang#124266 - RalfJung:no-answer, r=joboet

remove an unused type from the reentrant lock tests

At least it seems unused. This was added back in 45aa6c8 together with a test related to poisoning; when the test got removed, it seems like it was forgotten to also remove this type.
@rustbot rustbot added this to the 1.79.0 milestone Apr 23, 2024
@RalfJung RalfJung deleted the no-answer branch April 23, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants