Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -lmingwex second time in mingw_libs #124233

Merged
merged 1 commit into from
May 11, 2024
Merged

Add -lmingwex second time in mingw_libs #124233

merged 1 commit into from
May 11, 2024

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Apr 21, 2024

Upcoming mingw-w64 releases will contain small math functions refactor which moved implementation around. As a result functions like lgamma
now depend on libraries in this order:
libmingwex.a -> libmsvcrt.a -> libmingwex.a.

Fixes #124221

@mati865
Add -lmingwex second time in mingw_libs
eac0b3a 
Upcoming mingw-w64 releases will contain small math functions refactor which moved implementation around.
As a result functions like `lgamma`
now depend on libraries in this order:
`libmingwex.a` -> `libmsvcrt.a` -> `libmingwex.a`.

Fixes rust-lang#124221
@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2024

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 21, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

@ChrisDenton
Copy link
Member

Would it be possible to use --start-group and --end-group? I fear otherwise we may be having to do something like this again and again.

@mati865
Copy link
Contributor Author

mati865 commented Apr 21, 2024

In the long run that would be better solution but it was discussed 2 or 3 years ago but nothing has happened since then.

@ChrisDenton
Copy link
Member

Right but this code looks like it is just setting linker arguments directly, no? So couldn't it just add the group manually for these libs?

@mati865
Copy link
Contributor Author

mati865 commented Apr 22, 2024

Yes, it should work, but I don't know if it's okay to do it. Previous talks were about a more generic solution.

@Noratrieb
Copy link
Member

I'd say set it and see what happens^^. More generic solutions would always be good but no reason to block using it here over them (unless there is a very good reason). cc @petrochenkov

@petrochenkov petrochenkov self-assigned this Apr 22, 2024
@nnethercote nnethercote removed their assignment Apr 22, 2024
@nnethercote
Copy link
Contributor

I will defer to @petrochenkov here.

@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 10, 2024

📌 Commit eac0b3a has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2024
@jieyouxu jieyouxu mentioned this pull request May 11, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2024
@bors
Auto merge of rust-lang#124993 - jieyouxu:rollup-u02aso7, r=jieyouxu
f9a3fd9 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#124233 (Add `-lmingwex` second time in `mingw_libs`)
 - rust-lang#124318 (ignore generics args in attribute paths)
 - rust-lang#124899 (bootstrap: add comments for the automatic dry run)
 - rust-lang#124904 (reachable computation: extend explanation of what this does, and why)
 - rust-lang#124930 (Make sure we consume a generic arg when checking mistyped turbofish)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 150633e into rust-lang:master May 11, 2024
12 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 11, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2024
@rust-timer
Unrolled build for rust-lang#124233
c277b80 
Rollup merge of rust-lang#124233 - mati865:fix-support-for-upcoming-mingw-w64, r=petrochenkov

Add `-lmingwex` second time in `mingw_libs`

Upcoming mingw-w64 releases will contain small math functions refactor which moved implementation around. As a result functions like `lgamma`
now depend on libraries in this order:
`libmingwex.a` -> `libmsvcrt.a` -> `libmingwex.a`.

Fixes rust-lang#124221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.

Future version of mingw-w64 breaks externally linking some math functions
7 participants
@mati865 @rustbot @ChrisDenton @Noratrieb @nnethercote @petrochenkov @bors