Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: don't use rayon for sysinfo #124155

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Apr 19, 2024

It's looks overkill to use rayon to collect cpu usage

It's looks overkill to use rayon to collect cpu usage
@rustbot
Copy link
Collaborator

rustbot commented Apr 19, 2024

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 19, 2024
Copy link
Member

@albertlarsan68 albertlarsan68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@albertlarsan68
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 19, 2024

📌 Commit 6612ad7 has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 19, 2024
…arsan68

bootstrap: don't use rayon for sysinfo

It's looks overkill to use rayon to collect cpu usage
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#123571 (Correctly change type when adding adjustments on top of `NeverToAny`)
 - rust-lang#123729 (run-make: refactor out command wrappers for `clang` and `llvm-readobj`)
 - rust-lang#124149 (rustdoc-search: fix description on aliases in results)
 - rust-lang#124155 (bootstrap: don't use rayon for sysinfo)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#123571 (Correctly change type when adding adjustments on top of `NeverToAny`)
 - rust-lang#123729 (run-make: refactor out command wrappers for `clang` and `llvm-readobj`)
 - rust-lang#124106 (Don't repeatedly duplicate TAIT lifetimes for each subsequently nested TAIT)
 - rust-lang#124149 (rustdoc-search: fix description on aliases in results)
 - rust-lang#124155 (bootstrap: don't use rayon for sysinfo)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f1e536d into rust-lang:master Apr 19, 2024
12 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 19, 2024
Rollup merge of rust-lang#124155 - klensy:wrong-rayon-here, r=albertlarsan68

bootstrap: don't use rayon for sysinfo

It's looks overkill to use rayon to collect cpu usage
@rustbot rustbot added this to the 1.79.0 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants