Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stablise io_error_downcast #124076

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Stablise io_error_downcast #124076

merged 1 commit into from
Apr 26, 2024

Conversation

NobodyXu
Copy link
Contributor

@NobodyXu NobodyXu commented Apr 17, 2024 •
edited
Loading

Tracking issue #99262
Closes #99262

FCP completed in #99262 (comment)

@rustbot
Copy link
Collaborator

rustbot commented Apr 17, 2024

r? @m-ou-se

rustbot has assigned @m-ou-se.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 17, 2024
@dtolnay dtolnay added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2024
@dtolnay dtolnay assigned dtolnay and unassigned m-ou-se Apr 17, 2024
dtolnay
dtolnay approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but there are at least 8 more days left in the final comment period before this can be stabilized.

@NobodyXu
Copy link
Contributor Author

Thanks, I didn't know that because this is my first time doing stabilisation and also didn't find it in doc or bors output.

I would wait for 8 days and then ping you, once FCP is considered complete.

@NobodyXu NobodyXu mentioned this pull request Apr 24, 2024
Closed
5 tasks
@NobodyXu
Copy link
Contributor Author

@dtolnay FCP has completed now #99262 (comment)

dtolnay
dtolnay approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Apr 25, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Apr 25, 2024

📌 Commit 7b53f69 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 25, 2024
@compiler-errors compiler-errors mentioned this pull request Apr 26, 2024
Merged
@bors
Copy link
Contributor

bors commented Apr 26, 2024

⌛ Testing commit 7b53f69 with merge bc30c72...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 26, 2024
@bors
Auto merge of rust-lang#124076 - NobodyXu:patch-1, r=dtolnay
bc30c72 
Stablise io_error_downcast

Tracking issue rust-lang#99262
Closes rust-lang#99262

FCP completed in rust-lang#99262 (comment)
@compiler-errors
Copy link
Member

@bors retry yield to rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 26, 2024
@bors
Auto merge of rust-lang#124388 - compiler-errors:rollup-v17b8fm, r=co…
e59f2c5 
…mpiler-errors

Rollup of 4 pull requests

Successful merges:

 - rust-lang#124076 (Stablise io_error_downcast)
 - rust-lang#124378 (Keep the LIB env var in the compiler-builtins test)
 - rust-lang#124379 (Remove special-casing for `SimplifiedType` for next solver)
 - rust-lang#124381 (Renamed `DerivedObligation` to `WellFormedDeriveObligation`)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors bors merged commit 6f5c69e into rust-lang:master Apr 26, 2024
12 of 13 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 26, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 26, 2024
@rust-timer
Unrolled build for rust-lang#124076
391050e 
Rollup merge of rust-lang#124076 - NobodyXu:patch-1, r=dtolnay

Stablise io_error_downcast

Tracking issue rust-lang#99262
Closes rust-lang#99262

FCP completed in rust-lang#99262 (comment)
@NobodyXu NobodyXu deleted the patch-1 branch April 26, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.

Tracking Issue for io_error_downcast
7 participants
@NobodyXu @rustbot @dtolnay @bors @compiler-errors @rust-log-analyzer @m-ou-se