Rollup of 10 pull requests #124026
Merged
Rollup of 10 pull requests #124026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were checking the LLVM stamp before fetching the submodule which leads to not being able to compile llvm on submodule updates. Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
…ts passed to the driver
It's been 7 months since we deprecated this. It should be fine to remove it now. Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
Windows: add basic support for FormatMessageW
fix error display for './miri run --dep' Fixes rust-lang/miri#3463
Handle Miri sysroot entirely outside the Miri driver (Extracted from rust-lang/miri#3409) This entirely moves the responsibility of setting miri-sysroot to whatever *invokes* the Miri driver. cargo-miri knows whether it is inside rustdoc or not and can adjust accordingly. I previously avoided doing that because there are a bunch of places that are invoking the driver (cargo-miri, the ui test suite, `./miri run`, `./x.py run miri`) and they all need to be adjusted now. But it is also somewhat less fragile as we usually have more information there -- and we can just decide that `./miri run file.rs --sysroot path` is not supported. The advantage of this is that the driver is reasonably clean and doesn't need magic environment variables like MIRI_SYSROOT, and we don't have to fight rustc_driver to use a different default sysroot. Everything is done in cargo-miri (and the other much simpler driver wrappers) where it can hopefully be debugged much better.
add some basic support for GetFullPathNameW This is the last missing piece to make std `path::` tests work on Windows.
It will allow more flexible uses in the future. This makes `split_simd_to_128bit_chunks` simpler, moving some of the complexity to its callers.
We assert that we are in the new solver in the line above
Make `split_simd_to_128bit_chunks` take only one operand It will allow more flexible uses in the future. This makes `split_simd_to_128bit_chunks` simpler, moving some of the complexity to its callers.
Bump rustc-build-sysroot to 0.4.6 Fixes rust-lang#3313
Rustfix remains TODO
The lint is unstable, and the lint group `rust_2024_compatibility` must keep working on stable
Co-authored-by: Guillaume Boisseau <[email protected]>
…ding_mode_2024, r=Nadrieril Match ergonomics 2024: `mut` doesn't reset binding mode r? ``@Nadrieril`` cc rust-lang#123076 ``@rustbot`` label A-edition-2024 A-patterns
…albertlarsan68 drop `changelog-seen` It's been 7 months since we deprecated this. It should be fine to remove it now.
…mpiler-errors The new solver ignores `DefineOpaqueTypes`, so switch it to `Yes` We assert that we are in the new solver in the line above r? ``@compiler-errors``
Miri subtree update r? ``@ghost``
…mpiler-errors Change a diagnostics-path-only `DefineOpaqueTypes` to `Yes`. This can't possibly affect compilation, so it's safe to flip, even if I couldn't come up with an affected test r? ``@compiler-errors``
…i-obk interpret: pass MemoryKind to before_memory_deallocation This will be needed for rust-lang/miri#3475. r? ``@oli-obk``
interpret: remove outdated comment In rust-lang#107756, allocation became generally fallible, so the "only panic if there is provenance" no longer applies. r? ``@oli-obk``
rustbot
added
A-meta
|
@bors r+ rollup=never p=10 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 1dea922ea6 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Apr 16, 2024
Closed
Merged
|
Finished benchmarking commit (468f115): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 679.507s -> 677.864s (-0.24%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
--check-cfgoption #123501 (Stabilize checking of cfgs at compile-time:--check-cfgoption)mutdoesn't reset binding mode #123535 (Match ergonomics 2024:mutdoesn't reset binding mode)changelog-seen#123711 (dropchangelog-seen)DefineOpaqueTypes, so switch it toYes#123969 (The new solver ignoresDefineOpaqueTypes, so switch it toYes)DefineOpaqueTypestoYes. #124017 (Change a diagnostics-path-onlyDefineOpaqueTypestoYes.)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup