Fix cannot usage in time.rs #123815
Fix cannot usage in time.rs #123815
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @workingjubilee (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
|
@trueb2 This is not ungrammatical? |
|
@workingjubilee yes, the standard usage would be cannot. https://www.merriam-webster.com/grammar/cannot-vs-can-not-is-there-a-difference |
|
It says preferred, not standard, and that
And I would prefer to not introduce noise into the history over such a whitespace-only diff with no stronger reasoning. |
|
@trueb2 There are other, more glaring and unquestionable, grammatical issues in this file. I can accept this if it either
I do not desire to set a trend of encouraging people to closely review the comments, viewed only by implementers, for rigid adherence to prescriptivist notions of English grammar. We have contributors from all over the world, and it would be an untenable barrier to set holding people to strict adherence to Chicago MoS or AP Style in comments, and we do not document which stylebook we would prefer people to adhere to, either. |
|
I only opened the PR because the grammar was wrong in a panic message. Code comments don't affect end users, so I figured I was being nice by fixing the cannot usage everywhere. I assumed it was noise to fix all of the grammar. |
|
I am mostly concerned about precedent. Squash please? |
|
Ah! @bors r+ rollup |
bors
added
S-waiting-on-bors
Fix cannot usage in time.rs Fix a small grammar error in usage of cannot in time.rs errors
Fix cannot usage in time.rs Fix a small grammar error in usage of cannot in time.rs errors
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#122492 (Implement ptr_as_ref_unchecked) - rust-lang#123815 (Fix cannot usage in time.rs) - rust-lang#124059 (default_alloc_error_hook: explain difference to default __rdl_oom in alloc) - rust-lang#124510 (Add raw identifier in a typo suggestion) - rust-lang#124555 (coverage: Clean up creation of MC/DC condition bitmaps) - rust-lang#124593 (Describe and use CStr literals in CStr and CString docs) - rust-lang#124630 (CI: remove `env-x86_64-apple-tests` YAML anchor) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#123815 - trueb2:patch-1, r=workingjubilee Fix cannot usage in time.rs Fix a small grammar error in usage of cannot in time.rs errors
Fix a small grammar error in usage of cannot in time.rs errors