Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

rust-lang / rust Public

Notifications You must be signed in to change notification settings
Fork 14.3k
Star 109k

Code
Issues 5k+
Pull requests 980
Actions
Projects 9
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

Remove `DefId`'s `Partial/Ord` impls#122832

Merged

bors merged 20 commits intorust-lang:masterrust-lang/rust:masterfrom

oli-obk:no_ord_def_id3oli-obk/rust:no_ord_def_id3Copy head branch name to clipboard

Mar 28, 2024

Conversation Commits20 (20)Checks Files changed

Merged

Remove `DefId`'s `Partial/Ord` impls#122832
bors merged 20 commits intorust-lang:masterfrom
oli-obk:no_ord_def_id3

Commits

Commits on Mar 27, 2024

Remove unnecessary `Partial/Ord` derive
oli-obk
committed
Use `TraitRef::to_string` sorting in favor of `TraitRef::ord`, as the latter compares `DefId`s which we need to avoid
oli-obk
committed
Use FxIndexMap instead of BTreeMap to avoid sorting `DefId`s
oli-obk
committed
Sort diagnostics by rendered trait ref instead of its def ids
oli-obk
committed
Remove `Ord` from `Ty`, `Const`, and `Region`
oli-obk
committed
Remove `Ord` from `Binder`
oli-obk
committed
Remove `Ord` from `BoundTy`
oli-obk
committed
Remove `Partial/Ord` from `BoundRegion`
oli-obk
committed
Remove `Partial/Ord` from `AdtDef`
oli-obk
committed
Remove `Partial/Ord` from `EarlyParamRegion`
oli-obk
committed
Do not sort `DefId`s in diagnostics
oli-obk
committed
Don't sort `DefId`s in suggestions
oli-obk
committed
Sort method suggestions by `DefPath` instead of `DefId`
oli-obk
committed
Sort a diagnostic by `DefPathStr` instead of `DefId`
oli-obk
committed
Sort somem diagnostics by `DefPathStr` instead of `DefId`
oli-obk
committed
Stop sorting `DefId`s in the compiler
oli-obk
committed
Remove `DefId`'s `Partial/Ord` impls
oli-obk
committed
Ensure no one re-adds `Partial/Ord` impls for `DefId`
oli-obk
committed
Add rustdoc hack
oli-obk
committed
Int constants must be valtrees in pattern lowering
oli-obk
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.