Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change only_local to a enum type. #122695

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Change only_local to a enum type. #122695

merged 1 commit into from
Mar 19, 2024

Conversation

surechen
Copy link
Contributor

@surechen surechen commented Mar 18, 2024 •
edited
Loading

Change only_local to enum type and change the macros to always require a variant of that enum.

r? @lcnr

@rustbot
Copy link
Collaborator

rustbot commented Mar 18, 2024

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 18, 2024
@rustbot rustbot assigned lcnr and unassigned petrochenkov Mar 18, 2024
@lcnr
Copy link
Contributor

lcnr commented Mar 18, 2024

you need to rebase to the newest master branch

@surechen surechen force-pushed the make_only_local_explict_argument branch from 5673e6a to 950ea97 Compare March 19, 2024 02:08
@surechen
Copy link
Contributor Author

you need to rebase to the newest master branch

Done. Thank you.

@Noratrieb
Copy link
Member

Can we invert it and call it EncodeCrossCrate instead? I think that makes it more directly clear what it means.

@surechen
Copy link
Contributor Author

Can we invert it and call it EncodeCrossCrate instead? I think that makes it more directly clear what it means.

Agreed, EncodeCrossCrate is clearer to me, I'll adjust it. Thank you.

@surechen surechen force-pushed the make_only_local_explict_argument branch from 950ea97 to c941fa4 Compare March 19, 2024 09:38
lcnr
lcnr reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after nits, thanks!

compiler/rustc_feature/src/builtin_attrs.rs Outdated Show resolved Hide resolved
compiler/rustc_feature/src/builtin_attrs.rs Outdated Show resolved Hide resolved
compiler/rustc_middle/src/ty/mod.rs Outdated Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@surechen surechen force-pushed the make_only_local_explict_argument branch from c941fa4 to a0d7715 Compare March 19, 2024 11:27
@surechen surechen force-pushed the make_only_local_explict_argument branch from a0d7715 to db48dfc Compare March 19, 2024 12:18
@lcnr
Copy link
Contributor

lcnr commented Mar 19, 2024

thanks

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 19, 2024

📌 Commit db48dfc has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 19, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 19, 2024
@bors
Auto merge of rust-lang#122735 - matthiaskrgr:rollup-pgb1s90, r=matth…
e760daa 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#122435 (Don't trigger `unused_qualifications` on global paths)
 - rust-lang#122556 (Extend format arg help for simple tuple index access expression)
 - rust-lang#122634 (compiletest: Add support for `//@ aux-bin: foo.rs`)
 - rust-lang#122677 (Fix incorrect mutable suggestion information for binding in ref pattern.)
 - rust-lang#122691 (Fix ICE: `global_asm!()` Don't Panic When Unable to Evaluate Constant)
 - rust-lang#122695 (Change only_local to a enum type.)
 - rust-lang#122717 (Ensure stack before parsing dot-or-call)
 - rust-lang#122719 (Ensure nested statics have a HIR node to prevent various queries from ICEing)
 - rust-lang#122720 ([doc]:fix error code example)
 - rust-lang#122724 (add test for casting pointer to union with unsized tail)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ea7ea2d into rust-lang:master Mar 19, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 19, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 19, 2024
@rust-timer
Unrolled build for rust-lang#122695
453d0e4 
Rollup merge of rust-lang#122695 - surechen:make_only_local_explict_argument, r=lcnr

Change only_local to a enum type.

Change only_local to enum type and change the macros to always require a variant of that enum.

r? `@lcnr`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcnr lcnr lcnr left review comments

Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
7 participants
@surechen @rustbot @lcnr @Noratrieb @rust-log-analyzer @bors @petrochenkov