Cleaning up core crates dependencies on libextra #12255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that with some polish we may be able to add the We do indeed need some form of time abstraction in a few places throughout libstd, but Perhaps |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 26, 2024
Take lifetime extension into account in `ref_as_ptr` fixes rust-lang#12255 This should be merged upstream as well. Changing `let x = &temp as *const _` into `let x = from_ref(&temp)` is UB. changelog: `ref_as_ptr`: Take lifetime extension into account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A key part of splitting, and therefore removing libextra (#8784) would be to remove other core crates' dependencies on it.
I've started off with libsyntax, which didn't even require anything from libextra.
When I went to go and cleanup librustc, I came across a few requirements, and I'm not sure how these should be handled. Some just don't seem like they need to be in their own crate:
extra::time. My initial thought would be alibtime, but perhaps it could go inlibstd?extra::tempfile. I think this should be part ofstd::io::fs, but I wanted to check first.extra::enum_set. I honestly have no idea where this would belong.Any input on where those three should go?