-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crater rollup #122502
Crater rollup #122502
Conversation
…ing scope" is actually needed
@bors try |
Crater rollup This is a crater rollup of: - [ ] rust-lang#122317 - [ ] rust-lang#122501 - [ ] rust-lang#122077 What does that mean? Well, I'm gonna run crater with p=3 on this PR, and then re-run *just* the list of failed crates on each PR. That should deduplicate the bulk of crates which we expect are unaffected by these PRs. Don't touch this PR please. r? `@ghost`
2da279c
to
e6184af
Compare
@bors try |
Crater rollup This is a crater rollup of: - [ ] rust-lang#122317 - [ ] rust-lang#122501 - [ ] rust-lang#122077 What does that mean? Well, I'm gonna run crater with p=3 on this PR, and then re-run *just* the list of failed crates on each PR. That should deduplicate the bulk of crates which we expect are unaffected by these PRs. Don't touch this PR please. r? `@ghost`
The job Click to see the possible cause of the failure (guessed by this bot)
|
The job Click to see the possible cause of the failure (guessed by this bot)
|
☀️ Try build successful - checks-actions |
@craterbot check start=80399064afa4a2cd153f30d02c25f7ea0383ed65 name=crater-rollup p=4 |
🚨 Error: missing end toolchain 🆘 If you have any trouble with Crater please ping |
@craterbot check start=80399064afa4a2cd153f30d02c25f7ea0383ed65 end= try#51303093d7bd211231c50ae4c61616049d99e4dd name=crater-rollup p=4 |
🚨 Error: failed to parse the command 🆘 If you have any trouble with Crater please ping |
SIGH crater please @craterbot check start=80399064afa4a2cd153f30d02c25f7ea0383ed65 end=51303093d7bd211231c50ae4c61616049d99e4dd name=crater-rollup p=4 |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
@craterbot cancel |
🗑️ Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
Forbid unprefixed SHAs for toolchains This PR forbids unprefixed SHAs for toolchain arguments, to avoid crater hanging when they appear. I'm not sure this is fully valid though: I don't know if SHAs could appear in a `Toolchain`'s name (and `RustwideToolchain::dist()`) without being an error 😓. This commonly happens with `rustup-toolchain-install-master` but I don't know if a similar situation could arise within common crater usage. CI will surely fail: some of the used dependencies are broken on nightly right now, and clippy emits warnings -- both issues are fixed in #722. <sub>(this is [for](rust-lang/rust#122230 (comment)) `@oli-obk` and [for](rust-lang/rust#122502 (comment)) `@compiler-errors)</sub>`
Forbid unprefixed SHAs for toolchains This PR forbids unprefixed SHAs for toolchain arguments, to avoid crater hanging when they appear. I'm not sure this is fully valid though: I don't know if SHAs could appear in a `Toolchain`'s name (and `RustwideToolchain::dist()`) without being an error 😓. This commonly happens with `rustup-toolchain-install-master` but I don't know if a similar situation could arise within common crater usage. CI will surely fail: some of the used dependencies are broken on nightly right now, and clippy emits warnings -- both issues are fixed in #722. <sub>(this is [for](rust-lang/rust#122230 (comment)) `@oli-obk` and [for](rust-lang/rust#122502 (comment)) `@compiler-errors)</sub>`
This is a crater rollup of:
What does that mean? Well, I'm gonna run crater with p=3 on this PR, and then re-run just the list of failed crates on each PR. That should deduplicate the bulk of crates which we expect are unaffected by these PRs.
Don't touch this PR please.
Once this crater run has ended, then we can start much smaller
craterbot crates=...
runs on the above PRs with just the affected list of crates.r? @ghost