Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cargo update PR more often #122489

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Conversation

clubby789
Copy link
Contributor

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 14, 2024
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 16, 2024

📌 Commit 39e36af has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 16, 2024
…enton

Rollup of 7 pull requests

Successful merges:

 - rust-lang#122323 (configure.py: add flag for loongarch64 musl-root)
 - rust-lang#122372 (prevent notifying the same changes more than once)
 - rust-lang#122390 (Bump windows-bindgen to 0.55.0)
 - rust-lang#122401 (Check library crates for all tier 1 targets in PR CI)
 - rust-lang#122489 (Bump `cargo update` PR more often)
 - rust-lang#122583 (Use `UnsafeCell` for fast constant thread locals)
 - rust-lang#122590 (bootstrap: Don't name things copy that are not copies)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 42e03fc into rust-lang:master Mar 16, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 16, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 16, 2024
Rollup merge of rust-lang#122489 - clubby789:more-cargo-update, r=Mark-Simulacrum

Bump `cargo update` PR more often

r? `@Mark-Simulacrum`

(rust-lang#121923 (comment))
@saethlin
Copy link
Member

saethlin commented Mar 18, 2024

@clubby789 I'm not an expert on GitHub Actions/Workflows; I think this rla comment on my unrelated PR is somehow related to this PR landing: #122646 (comment)

But I'm not sure how that's possible. I feel like there's either a bug in this PR, or a bug in GitHub Actions. What do you think?

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 23, 2024
…Mark-Simulacrum

Cancel `cargo update` job if there's no updates

Previously there were always updates so we didn't hit this. Since rust-lang#122489, this job runs on a more frequent schedule and causes errors if there have been no changes in that timespan.

This led to a weird error on rust-lang#122646 (comment) - because of this I've replaced the `exit 1`s here with `gh run cancel` so we don't have false 'failed' jobs in the logs.
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 23, 2024
…Mark-Simulacrum

Cancel `cargo update` job if there's no updates

Previously there were always updates so we didn't hit this. Since rust-lang#122489, this job runs on a more frequent schedule and causes errors if there have been no changes in that timespan.

This led to a weird error on rust-lang#122646 (comment) - because of this I've replaced the `exit 1`s here with `gh run cancel` so we don't have false 'failed' jobs in the logs.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 23, 2024
…Mark-Simulacrum

Cancel `cargo update` job if there's no updates

Previously there were always updates so we didn't hit this. Since rust-lang#122489, this job runs on a more frequent schedule and causes errors if there have been no changes in that timespan.

This led to a weird error on rust-lang#122646 (comment) - because of this I've replaced the `exit 1`s here with `gh run cancel` so we don't have false 'failed' jobs in the logs.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 23, 2024
…Mark-Simulacrum

Cancel `cargo update` job if there's no updates

Previously there were always updates so we didn't hit this. Since rust-lang#122489, this job runs on a more frequent schedule and causes errors if there have been no changes in that timespan.

This led to a weird error on rust-lang#122646 (comment) - because of this I've replaced the `exit 1`s here with `gh run cancel` so we don't have false 'failed' jobs in the logs.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2024
Rollup merge of rust-lang#122698 - clubby789:cancel-hourly-update, r=Mark-Simulacrum

Cancel `cargo update` job if there's no updates

Previously there were always updates so we didn't hit this. Since rust-lang#122489, this job runs on a more frequent schedule and causes errors if there have been no changes in that timespan.

This led to a weird error on rust-lang#122646 (comment) - because of this I've replaced the `exit 1`s here with `gh run cancel` so we don't have false 'failed' jobs in the logs.
RenjiSann pushed a commit to RenjiSann/rust that referenced this pull request Mar 25, 2024
…Mark-Simulacrum

Cancel `cargo update` job if there's no updates

Previously there were always updates so we didn't hit this. Since rust-lang#122489, this job runs on a more frequent schedule and causes errors if there have been no changes in that timespan.

This led to a weird error on rust-lang#122646 (comment) - because of this I've replaced the `exit 1`s here with `gh run cancel` so we don't have false 'failed' jobs in the logs.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 26, 2024
…=Kobzol

Revert `cargo update` changes and bump `download-artifact` to v4

Revert rust-lang#122489 and rust-lang#122698

rust-lang#122951 (comment)
The failures + rust-lang/rust-log-analyzer#81 are causing some annoying spam. I don't think this is _that_ important for now and I don't know enough GHA to fix it 😓
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 26, 2024
Rollup merge of rust-lang#123069 - clubby789:un-often-cargo-update, r=Kobzol

Revert `cargo update` changes and bump `download-artifact` to v4

Revert rust-lang#122489 and rust-lang#122698

rust-lang#122951 (comment)
The failures + rust-lang/rust-log-analyzer#81 are causing some annoying spam. I don't think this is _that_ important for now and I don't know enough GHA to fix it 😓
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants