-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assert that we only use compare-exchange on pointers and no other rmw op #122428
Conversation
This comment has been minimized.
This comment has been minimized.
looks like libcore tests actually invoke this 😆 |
This comment has been minimized.
This comment has been minimized.
The job Click to see the possible cause of the failure (guessed by this bot)
|
@nikic so about
We do have
So the provenance is always of the original value and can't be changed with these operations. |
We can't really use |
☔ The latest upstream changes (presumably #122917) made this pull request unmergeable. Please resolve the merge conflicts. |
r? @saethlin @nikic
discussion that led up to this: #122220 (comment)
the other rmw ops make no sense for pointers (addition, ...)