`f16` and `f128` step 3: compiler support & feature gate #121926

tgross35 · 2024-03-03T02:54:54Z

Continuation of #121841, another portion of #114607

This PR exposes the new types to the world and adds a feature gate. Marking this as a draft because I need some feedback on where I did the feature gate check. It also does not yet catch type via suffixed literals (so the feature gate test will fail, probably some others too because I haven't belssed).

If there is a better place to check all types after resolution, I can do that. If not, I figure maybe I can add a second gate location in AST when it checks numeric suffixes.

Unfortunately I still don't think there is much testing to be done for correctness (codegen tests or parsed value checks) until we have basic library support. I think that will be the next step.

Tracking issue: #116909

r? @compiler-errors
cc @Nilstrieb
@rustbot label +F-f16_and_f128

tests/ui/parser/f16-f128.rs

compiler-errors

Are there any positive tests (i.e. ones that show that feature(f16)/feature(f128) actually allows us to name and use f16/f128)?

compiler/rustc_resolve/src/late.rs

compiler/rustc_ast_passes/src/feature_gate.rs

compiler/rustc_resolve/src/ident.rs

rustbot · 2024-03-04T19:04:19Z

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

tgross35 · 2024-03-04T19:05:28Z

Are there any positive tests (i.e. ones that show that feature(f16)/feature(f128) actually allows us to name and use f16/f128)?

I was thinking the feature gate test happened both with and without the gate but I guess not. Added tests/ui/resolve/primitive-usage.rs*

tests/ui/resolve/primitive-f128.rs

compiler-errors · 2024-03-04T20:12:19Z

@bors r+

bors · 2024-03-04T20:12:21Z

📌 Commit 1bc946b has been approved by compiler-errors

It is now in the queue for this repository.

tgross35 · 2024-03-04T20:17:43Z

I think that's the last of the compiler side for a while 🎉 thanks for the ton of help figuring this all out @compiler-errors

bors · 2024-03-15T09:50:31Z

📌 Commit 2098fec has been approved by compiler-errors,petrochenkov

It is now in the queue for this repository.

tgross35 · 2024-03-15T19:21:49Z

Wouldn't doing the gate in rustc_ast_lowering rather than after resolution mean that user-defined types named f16 or f128 also get flagged?

User defined types will result in Res::Def, not Res::PrimTy.

I only see Res::PrimTy being constructed once in ast_lowering at

rust/compiler/rustc_ast_lowering/src/item.rs

Lines 1580 to 1593 in 72d7897

    
           hir::TyKind::Path(hir::QPath::Resolved( 
        
               None, 
        
               self.arena.alloc(hir::Path { 
        
                   res: Res::PrimTy(hir::PrimTy::Bool), 
        
                   span, 
        
                   segments: self.arena.alloc_from_iter([hir::PathSegment { 
        
                       ident: Ident { name: sym::bool, span }, 
        
                       hir_id: bool_id, 
        
                       res: Res::PrimTy(hir::PrimTy::Bool), 
        
                       args: None, 
        
                       infer_args: false, 
        
                   }]), 
        
               }), 
        
           )),

, which looks to be for generics. The rest are in rustc_resolve/src/late.rs, which we intercept here.

Thanks for the r+. As-is should be workable for now then, I can later update this gating to your suggestion if it improves the situation with libs. I am just not exactly sure what this would look like still.

matthiaskrgr · 2024-03-15T20:47:24Z

@bors rollup=iffy

bors · 2024-03-15T23:23:39Z

⌛ Testing commit 2098fec with merge 76a9141...

…, r=compiler-errors,petrochenkov `f16` and `f128` step 3: compiler support & feature gate Continuation of rust-lang#121841, another portion of rust-lang#114607 This PR exposes the new types to the world and adds a feature gate. Marking this as a draft because I need some feedback on where I did the feature gate check. It also does not yet catch type via suffixed literals (so the feature gate test will fail, probably some others too because I haven't belssed). If there is a better place to check all types after resolution, I can do that. If not, I figure maybe I can add a second gate location in AST when it checks numeric suffixes. Unfortunately I still don't think there is much testing to be done for correctness (codegen tests or parsed value checks) until we have basic library support. I think that will be the next step. Tracking issue: rust-lang#116909 r? `@compiler-errors` cc `@Nilstrieb` `@rustbot` label +F-f16_and_f128

rust-log-analyzer · 2024-03-16T00:02:21Z

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] rustc_infer test:false 92.838
   Compiling rustc_mir_build v0.0.0 (/checkout/compiler/rustc_mir_build)
[RUSTC-TIMING] rustc_codegen_ssa test:false 90.945
   Compiling rustc_lint v0.0.0 (/checkout/compiler/rustc_lint)
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
##[group]Clock drift check
  local time: Sat Mar 16 00:01:55 UTC 2024
  local time: Sat Mar 16 00:01:55 UTC 2024
Session terminated, killing shell... ...killed.
##[error]The operation was canceled.
Cleaning up orphan processes

bors · 2024-03-16T00:02:46Z

💔 Test failed - checks-actions

tgross35 · 2024-03-16T00:19:40Z

Clock drift failed, I don’t think that’s from the changes

compiler-errors · 2024-03-16T00:20:35Z

@bors retry

bors · 2024-03-16T02:02:04Z

⌛ Testing commit 2098fec with merge c03ea3d...

bors · 2024-03-16T04:06:36Z

☀️ Test successful - checks-actions
Approved by: compiler-errors,petrochenkov
Pushing c03ea3d to master...

rust-timer · 2024-03-16T05:22:37Z

Finished benchmarking commit (c03ea3d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.3s -> 670.952s (0.10%)
Artifact size: 311.50 MiB -> 311.63 MiB (0.04%)

…r=Amanieu `f16` and `f128` step 4: basic library support This is the next step after rust-lang#121926, another portion of rust-lang#114607 Tracking issue: rust-lang#116909 This PR adds the most basic operations to `f16` and `f128` that get lowered as LLVM intrinsics. This is a very small step but it seemed reasonable enough to add unopinionated basic operations before the larger modules that are built on top of them. r? `@Amanieu` since you were pretty involved in the RFC cc `@compiler-errors` `@rustbot` label +T-libs-api +S-blocked +F-f16_and_f128

…r=Amanieu `f16` and `f128` step 4: basic library support This is the next step after rust-lang#121926, another portion of rust-lang#114607 Tracking issue: rust-lang#116909 This PR adds the most basic operations to `f16` and `f128` that get lowered as LLVM intrinsics. This is a very small step but it seemed reasonable enough to add unopinionated basic operations before the larger modules that are built on top of them. r? ``@Amanieu`` since you were pretty involved in the RFC cc ``@compiler-errors`` ``@rustbot`` label +T-libs-api +S-blocked +F-f16_and_f128

…r=Amanieu `f16` and `f128` step 4: basic library support This is the next step after rust-lang#121926, another portion of rust-lang#114607 Tracking issue: rust-lang#116909 This PR adds the most basic operations to `f16` and `f128` that get lowered as LLVM intrinsics. This is a very small step but it seemed reasonable enough to add unopinionated basic operations before the larger modules that are built on top of them. r? ```@Amanieu``` since you were pretty involved in the RFC cc ```@compiler-errors``` ```@rustbot``` label +T-libs-api +S-blocked +F-f16_and_f128

…Amanieu `f16` and `f128` step 4: basic library support This is the next step after rust-lang#121926, another portion of rust-lang#114607 Tracking issue: rust-lang#116909 This PR adds the most basic operations to `f16` and `f128` that get lowered as LLVM intrinsics. This is a very small step but it seemed reasonable enough to add unopinionated basic operations before the larger modules that are built on top of them. r? `@Amanieu` since you were pretty involved in the RFC cc `@compiler-errors` `@rustbot` label +T-libs-api +S-blocked +F-f16_and_f128

Rollup merge of rust-lang#122470 - tgross35:f16-f128-step4-libs-min, r=Amanieu `f16` and `f128` step 4: basic library support This is the next step after rust-lang#121926, another portion of rust-lang#114607 Tracking issue: rust-lang#116909 This PR adds the most basic operations to `f16` and `f128` that get lowered as LLVM intrinsics. This is a very small step but it seemed reasonable enough to add unopinionated basic operations before the larger modules that are built on top of them. r? ```@Amanieu``` since you were pretty involved in the RFC cc ```@compiler-errors``` ```@rustbot``` label +T-libs-api +S-blocked +F-f16_and_f128

rustbot assigned compiler-errors Mar 3, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. F-f16_and_f128 `#![feature(f16)]`, `#![feature(f128)]` labels Mar 3, 2024

tgross35 mentioned this pull request Mar 3, 2024

Tracking Issue for f16 and f128 float types #116909

Open

82 tasks

tgross35 force-pushed the f16-f128-step3-feature-gate branch from e509a89 to a7ce0b8 Compare March 3, 2024 03:09

This comment has been minimized.

Sign in to view

Noratrieb reviewed Mar 3, 2024

View reviewed changes

tests/ui/parser/f16-f128.rs Show resolved Hide resolved

tgross35 force-pushed the f16-f128-step3-feature-gate branch from a7ce0b8 to 9954861 Compare March 4, 2024 04:13

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 4, 2024

tgross35 force-pushed the f16-f128-step3-feature-gate branch 3 times, most recently from 8f1dbe9 to 603aeb6 Compare March 4, 2024 04:59

This comment has been minimized.

Sign in to view

tgross35 force-pushed the f16-f128-step3-feature-gate branch 2 times, most recently from 0e2b72c to d27edfb Compare March 4, 2024 05:31

compiler-errors reviewed Mar 4, 2024

View reviewed changes

tgross35 force-pushed the f16-f128-step3-feature-gate branch from d27edfb to b8af79d Compare March 4, 2024 19:01

tgross35 marked this pull request as ready for review March 4, 2024 19:04

RalfJung reviewed Mar 4, 2024

View reviewed changes

tests/ui/resolve/primitive-f128.rs Outdated Show resolved Hide resolved

tgross35 force-pushed the f16-f128-step3-feature-gate branch from b8af79d to 1bc946b Compare March 4, 2024 19:14

compiler-errors approved these changes Mar 4, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 16, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 16, 2024

bors merged commit c03ea3d into rust-lang:master Mar 16, 2024
12 checks passed

rustbot added this to the 1.78.0 milestone Mar 16, 2024

tgross35 deleted the f16-f128-step3-feature-gate branch March 16, 2024 04:07

matthiaskrgr mentioned this pull request Mar 16, 2024

ICE: not implemented: f16_f128 #122587

Closed

tgross35 mentioned this pull request Apr 2, 2024

Fix f16 and f128 feature gating on different editions #123307

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`f16` and `f128` step 3: compiler support & feature gate #121926

`f16` and `f128` step 3: compiler support & feature gate #121926

tgross35 commented Mar 3, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

compiler-errors left a comment

rustbot commented Mar 4, 2024

tgross35 commented Mar 4, 2024 •

edited

Loading

compiler-errors commented Mar 4, 2024

bors commented Mar 4, 2024

tgross35 commented Mar 4, 2024 •

edited

Loading

bors commented Mar 15, 2024

tgross35 commented Mar 15, 2024

matthiaskrgr commented Mar 15, 2024

bors commented Mar 15, 2024

rust-log-analyzer commented Mar 16, 2024

bors commented Mar 16, 2024

tgross35 commented Mar 16, 2024

compiler-errors commented Mar 16, 2024

bors commented Mar 16, 2024

bors commented Mar 16, 2024

rust-timer commented Mar 16, 2024

f16 and f128 step 3: compiler support & feature gate #121926

f16 and f128 step 3: compiler support & feature gate #121926

Conversation

tgross35 commented Mar 3, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

compiler-errors left a comment

Choose a reason for hiding this comment

rustbot commented Mar 4, 2024

tgross35 commented Mar 4, 2024 • edited Loading

compiler-errors commented Mar 4, 2024

bors commented Mar 4, 2024

tgross35 commented Mar 4, 2024 • edited Loading

bors commented Mar 15, 2024

tgross35 commented Mar 15, 2024

matthiaskrgr commented Mar 15, 2024

bors commented Mar 15, 2024

rust-log-analyzer commented Mar 16, 2024

bors commented Mar 16, 2024

tgross35 commented Mar 16, 2024

compiler-errors commented Mar 16, 2024

bors commented Mar 16, 2024

bors commented Mar 16, 2024

rust-timer commented Mar 16, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

`f16` and `f128` step 3: compiler support & feature gate #121926

`f16` and `f128` step 3: compiler support & feature gate #121926

tgross35 commented Mar 3, 2024 •

edited

Loading

tgross35 commented Mar 4, 2024 •

edited

Loading

tgross35 commented Mar 4, 2024 •

edited

Loading