Revert non-license changes as part of 0ebe112b #12173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit accidentally modified the snapshot script which changed its behavior and is currently blocking a snapshot.
|
The diff that I'm reverting is alexcrichton@0ebe112b#diff-1d2ff7986e29cdbb4a083e099fed93adL1 specifically |
bors
added a commit
that referenced
this pull request
Feb 11, 2014
The commit accidentally modified the snapshot script which changed its behavior and is currently blocking a snapshot.
|
Is it the spacing that was making it non-functional? |
|
Sadly good old python and its syntactical whitespace gave different meanings to this loop: https://github.com/mozilla/rust/pull/12173/files#diff-1d2ff7986e29cdbb4a083e099fed93adL151 No worries though, my editor does weird things to files all the time and I accidentally commit them! |
|
Weirdness, I had standardized spacing in that file since it was a mix of 2-spaces and 4-spaces indents. (That's really a sucky aspect of Python. Even at school when we began learning it some of the other students were confused by that "spacing is block" aspect.) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
internal: completion PathKind is not optional
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 25, 2024
blocks_in_conditions: do not warn if condition comes from macro changelog: [`blocks_in_conditions`]: do not warn if condition comes from macro Fix rust-lang#12162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit accidentally modified the snapshot script which changed its behavior
and is currently blocking a snapshot.