Detect more cases of = to : typo

[estebank]

When a Local is fully parsed, but not followed by a ;, keep the : span arround and mention it. If the type could continue being parsed as an expression, suggest replacing the : with a =.

error: expected one of `!`, `+`, `->`, `::`, `;`, or `=`, found `.`
 --> file.rs:2:32
  |
2 |     let _: std::env::temp_dir().join("foo");
  |          -                     ^ expected one of `!`, `+`, `->`, `::`, `;`, or `=`
  |          |
  |          while parsing the type for `_`
  |          help: use `=` if you meant to assign

Fix #119665.

[rustbot]

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Changes to the size of AST and/or HIR nodes.

cc @nnethercote

[davidtwco]

r=me after fixing the CI and a good perf run (ast size change)

[estebank]

@bors try @rust-timer queue

[bors]

⌛ Trying commit bde2dfb with merge 1dcfdd8...

[bors]

☀️ Try build successful - checks-actions
Build commit: 1dcfdd8 (1dcfdd875195ceab0eb65bec6f038a33e5d73eac)

[rust-timer]

Finished benchmarking commit (1dcfdd8): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.8%	[-2.8%, -2.8%]	1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.8%	[-2.8%, -2.8%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 651.937s -> 654.266s (0.36%)
Artifact size: 311.55 MiB -> 311.55 MiB (0.00%)

[estebank]

@bors r=davidtwco

the improvements are likely noise

[bors]

📌 Commit bde2dfb has been approved by davidtwco

It is now in the queue for this repository.

[bors]

⌛ Testing commit bde2dfb with merge 4cdd205...

[bors]

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 4cdd205 to master...

[rust-timer]

Finished benchmarking commit (4cdd205): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.7%	[1.4%, 2.1%]	2
Regressions ❌ (secondary)	3.7%	[2.6%, 5.2%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.2%	[-5.2%, -3.2%]	2
All ❌✅ (primary)	1.7%	[1.4%, 2.1%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 652.494s -> 653.837s (0.21%)
Artifact size: 175.45 MiB -> 175.50 MiB (0.03%)