Implement List's all() function #12160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we continue to go down this road, then the real answer here is to define an iterator for the |
|
Yeah :-) |
|
If we're going to go down that route, the whole API needs to be revisited. All these free functions should probably be methods. |
|
Right - do we update this now or let it for a further patch? |
|
I think let's close this for now, but feel free to open another PR with an iterator-based approach. |
|
IMHO, it's time to revisit the API as @kballard said. I'd prefer doing that instead of adding more methods to it. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
minor: Sort ide-completions test outputs for less disruptive diffs
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 8, 2024
…lyxyas Warn if an item coming from more recent version than MSRV is used Part of rust-lang/rust-clippy#6324. ~~Currently, the lint is not working for the simple reason that the `stable` attribute is not kept in dependencies. I'll send a PR to rustc to see if they'd be okay with keeping it.~~ EDIT: There was actually a `lookup_stability` function providing this information, so all good now! cc `@epage` changelog: create new [`incompatible_msrv`] lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As opposed to
any(),all()returns true if all list items matches the predicate, returning false otherwise.