-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use generic NonZero
everywhere in library
.
#121454
Conversation
This comment has been minimized.
This comment has been minimized.
36bb4d9
to
b74d8db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Delegating in case a merge conflict requires rebasing, as I already see in #121461 (comment)—feel free to use r=dtolnay after rebase. |
✌️ @reitermarkus, you can now approve this pull request! If @dtolnay told you to " |
@bors rollup=iffy |
☀️ Test successful - checks-actions |
Finished benchmarking commit (b6a23b8): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 649.924s -> 648.956s (-0.15%) |
Tracking issue: #120257
Use generic
NonZero
everywhere (except stable examples).r? @dtolnay