Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for inlining compiler-private items #121284

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Feb 19, 2024

Closes #106421

This was already fixed by #121218, but now the test cases are added.

@rustbot
Copy link
Collaborator

rustbot commented Feb 19, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 19, 2024
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 24, 2024

📌 Commit b9f0094 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 24, 2024
…r=Mark-Simulacrum

Add test cases for inlining compiler-private items

Closes rust-lang#106421

This was already fixed by rust-lang#121218, but now the test cases are added.
@matthiaskrgr
Copy link
Member

@bors r-
needs rebase #121565 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 24, 2024
Closes rust-lang#106421

This was already fixed by
f5d43a0, but now the test cases are
added.
@notriddle notriddle force-pushed the notriddle/issue-106421 branch from b9f0094 to 24aa348 Compare February 24, 2024 22:39
@notriddle
Copy link
Contributor Author

@bors r=Mark-Simulacrum rollup

@bors
Copy link
Contributor

bors commented Feb 24, 2024

📌 Commit 24aa348 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 24, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2024
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#119590 (Stabilize `cfg_target_abi`)
 - rust-lang#120805 (make non-PartialEq-typed consts as patterns a hard error)
 - rust-lang#121060 (Add newtypes for bool fields/params/return types)
 - rust-lang#121284 (Add test cases for inlining compiler-private items)
 - rust-lang#121324 (pattern_analysis: factor out unspecialization)
 - rust-lang#121409 (Prevent cycle in implied predicates computation)
 - rust-lang#121513 (Fix sgx unit test compilation)
 - rust-lang#121570 (Make most bootstrap step types !Copy)
 - rust-lang#121586 (Don't use `unwrap()` in `ArrayIntoIter` lint when typeck fails)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f780824 into rust-lang:master Feb 25, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 25, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2024
Rollup merge of rust-lang#121284 - notriddle:notriddle/issue-106421, r=Mark-Simulacrum

Add test cases for inlining compiler-private items

Closes rust-lang#106421

This was already fixed by rust-lang#121218, but now the test cases are added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing impl blocks when rustdoc inlines a type and -Zforce-unstable-if-unmarked is turned on
5 participants