Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for occupied niches #121174

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Check for occupied niches #121174

wants to merge 1 commit into from
+484 −13

Conversation

saethlin
Copy link
Member

This is a replacement for #104862

r? @ghost

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 16, 2024
@saethlin saethlin mentioned this pull request Feb 16, 2024
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Feb 16, 2024

☔ The latest upstream changes (presumably #120881) made this pull request unmergeable. Please resolve the merge conflicts.

@saethlin saethlin force-pushed the codegen-niche-checks branch from f1ea82e to 93a537f Compare February 17, 2024 00:07
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@saethlin saethlin force-pushed the codegen-niche-checks branch from 93a537f to 1da8347 Compare February 17, 2024 00:24
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Feb 22, 2024

☔ The latest upstream changes (presumably #121370) made this pull request unmergeable. Please resolve the merge conflicts.

@saethlin saethlin force-pushed the codegen-niche-checks branch from 1da8347 to 2335ab8 Compare February 23, 2024 22:18
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Mar 4, 2024

☔ The latest upstream changes (presumably #121955) made this pull request unmergeable. Please resolve the merge conflicts.

@saethlin saethlin force-pushed the codegen-niche-checks branch from 2335ab8 to 71e0b42 Compare March 5, 2024 00:48
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Mar 8, 2024

☔ The latest upstream changes (presumably #122190) made this pull request unmergeable. Please resolve the merge conflicts.

@saethlin saethlin force-pushed the codegen-niche-checks branch from 71e0b42 to 5c11b58 Compare March 23, 2024 19:01
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@saethlin saethlin force-pushed the codegen-niche-checks branch from 5c11b58 to 39f8046 Compare March 23, 2024 20:05
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Mar 24, 2024

☔ The latest upstream changes (presumably #122980) made this pull request unmergeable. Please resolve the merge conflicts.

@saethlin saethlin force-pushed the codegen-niche-checks branch from 39f8046 to 2c12cd5 Compare March 27, 2024 21:32
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@saethlin saethlin force-pushed the codegen-niche-checks branch from 2c12cd5 to 625ad60 Compare March 31, 2024 04:23
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Apr 2, 2024

☔ The latest upstream changes (presumably #123385) made this pull request unmergeable. Please resolve the merge conflicts.

@saethlin saethlin force-pushed the codegen-niche-checks branch from 625ad60 to 84ccc60 Compare April 3, 2024 12:18
@bors
Copy link
Contributor

bors commented May 21, 2024

☔ The latest upstream changes (presumably #125379) made this pull request unmergeable. Please resolve the merge conflicts.

@saethlin saethlin force-pushed the codegen-niche-checks branch from a2c0650 to 9c866bc Compare May 21, 2024 23:46
@bors
Copy link
Contributor

bors commented May 26, 2024

☔ The latest upstream changes (presumably #125574) made this pull request unmergeable. Please resolve the merge conflicts.

@saethlin saethlin force-pushed the codegen-niche-checks branch from 9c866bc to ae8f62f Compare May 26, 2024 21:21
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jul 28, 2024

☔ The latest upstream changes (presumably #128313) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC Dylan-DPC added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2024
@saethlin saethlin force-pushed the codegen-niche-checks branch from ae8f62f to b11e564 Compare September 2, 2024 01:45
@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Sep 2, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Sep 6, 2024

☔ The latest upstream changes (presumably #121614) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 6, 2024
@Dylan-DPC Dylan-DPC removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 9, 2024
@saethlin saethlin mentioned this pull request Nov 28, 2024
Closed
@saethlin saethlin force-pushed the codegen-niche-checks branch from b11e564 to 8e99635 Compare December 12, 2024 23:38
@saethlin saethlin removed A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-run-make Area: port run-make Makefiles to rmake.rs labels Dec 12, 2024
@saethlin
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 13, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 13, 2024
@bors
Auto merge of rust-lang#121174 - saethlin:codegen-niche-checks, r=<try>
19ff801 
Check for occupied niches

This is a replacement for rust-lang#104862

r? `@ghost`
@bors
Copy link
Contributor

bors commented Dec 13, 2024

⌛ Trying commit 8e99635 with merge 19ff801...

@bors
Copy link
Contributor

bors commented Dec 13, 2024

☀️ Try build successful - checks-actions
Build commit: 19ff801 (19ff80138a64ef0019dc36d1c33b9ba5618d14b4)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (19ff801): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 9.8% [0.2%, 41.4%] 72
Regressions ❌
(secondary)		 8.6% [0.2%, 37.2%] 35
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.4% [-0.6%, -0.3%] 6
All ❌✅ (primary) 9.8% [0.2%, 41.4%] 72

Max RSS (memory usage)

Results (primary 9.1%, secondary 2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 9.1% [1.0%, 33.8%] 26
Regressions ❌
(secondary)		 5.2% [1.0%, 10.6%] 5
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.4% [-5.3%, -3.6%] 2
All ❌✅ (primary) 9.1% [1.0%, 33.8%] 26

Cycles

Results (primary 13.3%, secondary 13.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 13.3% [1.5%, 30.9%] 43
Regressions ❌
(secondary)		 15.2% [3.9%, 30.5%] 15
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.6% [-3.8%, -3.5%] 2
All ❌✅ (primary) 13.3% [1.5%, 30.9%] 43

Binary size

Results (primary 10.4%, secondary 6.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 11.5% [0.0%, 35.5%] 74
Regressions ❌
(secondary)		 14.9% [2.6%, 52.7%] 28
Improvements ✅
(primary)		 -0.1% [-0.2%, -0.0%] 8
Improvements ✅
(secondary)		 -0.1% [-0.2%, -0.1%] 37
All ❌✅ (primary) 10.4% [-0.2%, 35.5%] 82

Bootstrap: 769.736s -> 772.551s (0.37%)
Artifact size: 331.09 MiB -> 331.01 MiB (-0.02%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
perf-regression Performance regression. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@saethlin @rust-log-analyzer @bors @rust-timer @rustbot @Dylan-DPC