ci update freebsd version proposal, freebsd 12 being eol

[devnexen]

raising to the lowest still active supported freebsd version.
From 13.1 (already eol too), freebsd introduces a cpu affinity layer
with linux. It also introduces a api compatible copy_file_range which
can be used like its linux's counterpart.
The former is essential to build #120589, therefore breaks the backward
compatibility with the previous FreeBSD releases.

Blocked on #130465

[rustbot]

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[Noratrieb]

Does this mean that the minimum supported version is raised? Or is freebsd backwards-compatible so that builds against a new version still run on the old versiom? (A thing that's, for example, not true for linux glibc).
Can you edit the description to describe the impact of this change this way?

[Mark-Simulacrum]

@rustbot author

Please update the PR description with details that @Nilstrieb asked for. It would probably also be a good idea to reflect in the platform support page (https://github.com/rust-lang/rust/blob/master/src/doc/rustc/src/platform-support.md) the target details if this does raise the minimum, so that users have something to reference for future Rust versions.

[devnexen]

@rustbot review

[Noratrieb]

What is the current minimum freebsd version supported by rustc? The platform support doc page doesn't document this.

[devnexen]

I would say freebsd 12.

[Noratrieb]

Thank you for adding it! Not in this PR, but it would be nice if you could add a new target documentation page in platform-support in src/doc/rustc for freebsd, adding yourself as the target maintainer (if you're interested) :).

I just looked it up, the last FreeBSD bump was #97944. It didn't include a blog post (which we do for bumps of more popular targets), so that seems fine. It superseded #89083 which contains more information.

Looks like we use FreeBSD artifacts on our CI mirror, so @Mark-Simulacrum (or someone else with permissions) will have to upload them first before this can be merged.

[Mark-Simulacrum]

I've put the artifacts in our mirror (2024-02-18-freebsd-13.2-i386-base.txz and 2024-02-18-freebsd-13.2-amd64-base.txz). Please update the download file to match those, and then we can move ahead.

[devnexen]

@rustbot review

[Mark-Simulacrum]

@bors r+ rollup=iffy

[bors]

📌 Commit 42d5b87 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[bors]

🌲 The tree is currently closed for pull requests below priority 50. This pull request will be tested once the tree is reopened.

[devnexen]

ping :) any luck ? unfortunately, it blocks further freebsd updates.

[bors]

☔ The latest upstream changes (presumably #121712) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #124404) made this pull request unmergeable. Please resolve the merge conflicts.

[RalfJung]

ping :) any luck ? unfortunately, it blocks further freebsd updates.

I interpret this as
@rustbot ready
(you can also do this yourself in the future)

That said, above you were asked to add some background and explanation to the PR description, which apparently has not happened yet.

[Mark-Simulacrum]

I see the clang version used for freebsd is identified as clang 6 which is suspicious :-) kind of old..

I don't know where that clang version is coming from. In general our dist builders often use older toolchains installed from e.g. Ubuntu LTS versions, if we need to build our own copy of clang that should generally be fine to add (see e.g. https://github.com/rust-lang/rust/blob/master/src/ci/docker/host-x86_64/dist-x86_64-linux/build-clang.sh).

That said, above you were asked to add some background and explanation to the PR description, which apparently has not happened yet.

Yeah, this would still be good to do.

@rustbot author

I don't think this is ready for another round of CI (unless I missed something), so setting back to waiting on author. I easily miss pings so would recommend setting to waiting-on-review as Ralf did if you need reviewer attention.

[devnexen]

I see the clang version used for freebsd is identified as clang 6 which is suspicious :-) kind of old..

I don't know where that clang version is coming from. In general our dist builders often use older toolchains installed from e.g. Ubuntu LTS versions, if we need to build our own copy of clang that should generally be fine to add (see e.g. https://github.com/rust-lang/rust/blob/master/src/ci/docker/host-x86_64/dist-x86_64-linux/build-clang.sh).

Sure but problem is, llvm would not compile with clang 6 ?

That said, above you were asked to add some background and explanation to the PR description, which apparently has not happened yet.

Yeah, this would still be good to do.

I ve done it.

[rustbot]

Some changes occurred in src/tools/cargo

cc @ehuss

[bors]

☔ The latest upstream changes (presumably #128461) made this pull request unmergeable. Please resolve the merge conflicts.

[alex-semenyuk]

@devnexen
Ping from triage. Are this waiting something beside solving merge conflicts?

[devnexen]

yes the build for freebsd need to be updated.

[alex-semenyuk]

@devnexen thanks, where we can track it update?

[devnexen]

It might be best to create an issue because it s complicated, it s using docker to build freebsd binaries with an old toolchain. Ideally, something like cirrus would be more ideal.

[devnexen]

Issue opened here.

[devnexen]

@Mark-Simulacrum would it be possible to give another try ? since I ve updated the Docker container version, it should come with a newer clang version.