-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #120649
Rollup of 8 pull requests #120649
Commits on Jan 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1eaeaaf - Browse repository at this point
Copy the full SHA 1eaeaafView commit details -
Configuration menu - View commit details
-
Copy full SHA for e05c779 - Browse repository at this point
Copy the full SHA e05c779View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33e5d85 - Browse repository at this point
Copy the full SHA 33e5d85View commit details
Commits on Jan 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 24aefa0 - Browse repository at this point
Copy the full SHA 24aefa0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9452d7e - Browse repository at this point
Copy the full SHA 9452d7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9152e2 - Browse repository at this point
Copy the full SHA e9152e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ab1d5d - Browse repository at this point
Copy the full SHA 3ab1d5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d765e3a - Browse repository at this point
Copy the full SHA d765e3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 732f6a1 - Browse repository at this point
Copy the full SHA 732f6a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1adda9a - Browse repository at this point
Copy the full SHA 1adda9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7135168 - Browse repository at this point
Copy the full SHA 7135168View commit details
Commits on Jan 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d63f10b - Browse repository at this point
Copy the full SHA d63f10bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c886d7 - Browse repository at this point
Copy the full SHA 1c886d7View commit details
Commits on Jan 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cd77d59 - Browse repository at this point
Copy the full SHA cd77d59View commit details
Commits on Jan 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5747ece - Browse repository at this point
Copy the full SHA 5747eceView commit details
Commits on Jan 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for edba949 - Browse repository at this point
Copy the full SHA edba949View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ad307d - Browse repository at this point
Copy the full SHA 7ad307dView commit details
Commits on Jan 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 65b1083 - Browse repository at this point
Copy the full SHA 65b1083View commit details
Commits on Jan 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 699b59c - Browse repository at this point
Copy the full SHA 699b59cView commit details -
Only suggest removal of
as_*
andto_
conversion methods on E0308Instead of ``` error[E0308]: mismatched types --> tests/ui/suggestions/only-suggest-removal-of-conversion-method-calls.rs:9:5 | 4 | fn get_name() -> String { | ------ expected `String` because of return type ... 9 | your_name.trim() //~ ERROR E0308 | ^^^^^^^^^^^^^^^^ expected `String`, found `&str` | help: try removing the method call | 9 - your_name.trim() 9 + your_name ``` output ``` error[E0308]: mismatched types --> $DIR/only-suggest-removal-of-conversion-method-calls.rs:9:5 | LL | fn get_name() -> String { | ------ expected `String` because of return type ... LL | your_name.trim() | ^^^^^^^^^^^^^^^^- help: try using a conversion method: `.to_string()` | | | expected `String`, found `&str` ``` Fix rust-lang#114329.
Configuration menu - View commit details
-
Copy full SHA for 44d8ecb - Browse repository at this point
Copy the full SHA 44d8ecbView commit details
Commits on Feb 1, 2024
-
On E0277 be clearer about implicit
Sized
bounds on type params and ……assoc types ``` error[E0277]: the size for values of type `[i32]` cannot be known at compilation time --> f100.rs:2:33 | 2 | let _ = std::mem::size_of::<[i32]>(); | ^^^^^ doesn't have a size known at compile-time | = help: the trait `Sized` is not implemented for `[i32]` note: required by an implicit `Sized` bound in `std::mem::size_of` --> /home/gh-estebank/rust/library/core/src/mem/mod.rs:312:22 | 312 | pub const fn size_of<T>() -> usize { | ^ required by the implicit `Sized` requirement on this bound in `size_of` ``` Fix rust-lang#120178.
Configuration menu - View commit details
-
Copy full SHA for c4c22b0 - Browse repository at this point
Copy the full SHA c4c22b0View commit details -
Change incr comp test when adding explicit
Sized
boundGiven the previous change to add implicit `Sized` bounds only if there isn't already an explicit `Sized` bound, now the incr comp machinery doesn't consider adding the explicit bound as being dirty, as long as `-Zincremental-ignore-spans` is set.
Configuration menu - View commit details
-
Copy full SHA for 95d9009 - Browse repository at this point
Copy the full SHA 95d9009View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b0ab54 - Browse repository at this point
Copy the full SHA 8b0ab54View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4feec41 - Browse repository at this point
Copy the full SHA 4feec41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0148da3 - Browse repository at this point
Copy the full SHA 0148da3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02320b5 - Browse repository at this point
Copy the full SHA 02320b5View commit details -
add test for try-block-in-match-arm
This is noted as an implementation concern under the tracking issue for `?` and `try` blocks. (Issue 31436)
Configuration menu - View commit details
-
Copy full SHA for bedd81e - Browse repository at this point
Copy the full SHA bedd81eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c0030f - Browse repository at this point
Copy the full SHA 2c0030fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f21e45 - Browse repository at this point
Copy the full SHA 0f21e45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0df6dfd - Browse repository at this point
Copy the full SHA 0df6dfdView commit details
Commits on Feb 4, 2024
-
Rollup merge of rust-lang#119759 - sfzhu93:master, r=cjgillot
Add FileCheck annotations to dataflow-const-prop tests part of rust-lang#116971. A few shadowing variable names are changed, so that it is easier to match the variable names in MIR using FileCheck syntax. Also, there's a FIXME in [enum.rs](https://github.com/rust-lang/rust/pull/119759/files#diff-7621f55327838e489a95ac99ae1e6126b37c57aff582594e6bee9d7e7e56fc58) because the MIR looks suspicious to me. It has been explained in the comments. r? cjgillot
Configuration menu - View commit details
-
Copy full SHA for 2b25957 - Browse repository at this point
Copy the full SHA 2b25957View commit details -
Rollup merge of rust-lang#120323 - estebank:issue-120178, r=fmease
On E0277 be clearer about implicit `Sized` bounds on type params and assoc types ``` error[E0277]: the size for values of type `[i32]` cannot be known at compilation time --> f100.rs:2:33 | 2 | let _ = std::mem::size_of::<[i32]>(); | ^^^^^ doesn't have a size known at compile-time | = help: the trait `Sized` is not implemented for `[i32]` note: required by an implicit `Sized` bound in `std::mem::size_of` --> /home/gh-estebank/rust/library/core/src/mem/mod.rs:312:22 | 312 | pub const fn size_of<T>() -> usize { | ^ required by the implicit `Sized` requirement on this bound in `size_of` ``` Fix rust-lang#120178.
Configuration menu - View commit details
-
Copy full SHA for 6af0458 - Browse repository at this point
Copy the full SHA 6af0458View commit details -
Rollup merge of rust-lang#120473 - estebank:issue-114329, r=TaKO8Ki
Only suggest removal of `as_*` and `to_` conversion methods on E0308 Instead of ``` error[E0308]: mismatched types --> tests/ui/suggestions/only-suggest-removal-of-conversion-method-calls.rs:9:5 | 4 | fn get_name() -> String { | ------ expected `String` because of return type ... 9 | your_name.trim() | ^^^^^^^^^^^^^^^^ expected `String`, found `&str` | help: try removing the method call | 9 - your_name.trim() 9 + your_name ``` output ``` error[E0308]: mismatched types --> $DIR/only-suggest-removal-of-conversion-method-calls.rs:9:5 | LL | fn get_name() -> String { | ------ expected `String` because of return type ... LL | your_name.trim() | ^^^^^^^^^^^^^^^^- help: try using a conversion method: `.to_string()` | | | expected `String`, found `&str` ``` Fix rust-lang#114329.
Configuration menu - View commit details
-
Copy full SHA for b23945c - Browse repository at this point
Copy the full SHA b23945cView commit details -
Rollup merge of rust-lang#120540 - Fishrock123:test-try-block-in-matc…
…h-arm, r=compiler-errors add test for try-block-in-match-arm This is noted as an implementation concern under the tracking issue for `?` and `try` blocks. (Issue 31436) Refs: rust-lang#31436
Configuration menu - View commit details
-
Copy full SHA for 592beb1 - Browse repository at this point
Copy the full SHA 592beb1View commit details -
Rollup merge of rust-lang#120547 - matthewjasper:complete-inline-cons…
…t-pat, r=compiler-errors `#![feature(inline_const_pat)]` is no longer incomplete Now that borrow checking and safety checking is implemented for inline constant patterns, the incomplete feature status is not necessary. Stabilizing this feature requires more testing and has some of the same unresolved questions as inline constants. cc rust-lang#76001
Configuration menu - View commit details
-
Copy full SHA for fa7d3e9 - Browse repository at this point
Copy the full SHA fa7d3e9View commit details -
Rollup merge of rust-lang#120552 - GuillaumeGomez:never-type-feature-…
…gate, r=compiler-errors Correctly check `never_type` feature gating Fixes rust-lang#120542. The feature wasn't tested on return type of a generic function type, so it got under the radar in rust-lang#120316. r? ```@compiler-errors```
Configuration menu - View commit details
-
Copy full SHA for c2ad283 - Browse repository at this point
Copy the full SHA c2ad283View commit details -
Rollup merge of rust-lang#120555 - pnkfelix:put-pnkfelix-back-on-revi…
…ew-queue, r=Mark-Simulacrum put pnkfelix (me) back on the review queue. I have more bandwidth and want to take on more review load.
Configuration menu - View commit details
-
Copy full SHA for 1547510 - Browse repository at this point
Copy the full SHA 1547510View commit details -
Rollup merge of rust-lang#120556 - fmease:improve-unused-generic-para…
…m-diags, r=oli-obk Improve the diagnostics for unused generic parameters * Don't emit two errors (namely E0091 *and* E0392) for unused type parameters on *lazy* type aliases * Fix the diagnostic help message of E0392 for *lazy* type aliases: Don't talk about the “fields” of lazy type aliases (use the term “body” instead) and don't suggest `PhantomData` for them, it doesn't make much sense * Consolidate the diagnostics for E0091 (unused type parameters in type aliases) and E0392 (unused generic parameters due to bivariance) and make it translatable * Still keep the error codes distinct (for now) * Naturally leads to better diagnostics for E0091 r? ```@oli-obk``` (to ballast your review load :P) or compiler
Configuration menu - View commit details
-
Copy full SHA for 7fa99bf - Browse repository at this point
Copy the full SHA 7fa99bfView commit details