Make a double-write UDP test more robust #12054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems a bit unlikely to me that the system would drop packets talking to itself. |
|
My guess is that both sends succeeded, but they collided and only one got received. Just a guess though? |
bors
added a commit
that referenced
this pull request
Feb 6, 2014
I have a hunch this just deadlocked the windows bots. Due to UDP being a lossy protocol, I don't think we can guarantee that the server can receive both packets, so just listen for one of them.
I have a hunch this just deadlocked the windows bots. Due to UDP being a lossy protocol, I don't think we can guarantee that the server can receive both packets, so just listen for one of them.
bors
added a commit
that referenced
this pull request
Feb 6, 2014
I have a hunch this just deadlocked the windows bots. Due to UDP being a lossy protocol, I don't think we can guarantee that the server can receive both packets, so just listen for one of them.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
Fix const generic panic in dyn trait fix rust-lang#12048
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 11, 2024
add external macro checks to `iter_without_into_iter` and `into_iter_without_iter` Fixes rust-lang#12037 I think it's useful to still lint on local macros, since the user should still be able to add another impl with the `IntoIterator` or `iter` method. I think it's also fairly common to write a macro for generating many impls (e.g. for many similar types), so it'd be nice if we can continue linting in those cases. For that reason I went with `in_external_macro`. I also added a test for `#[allow]`ing the lint while I was at it. changelog: [`iter_without_into_iter`]: don't lint if the `iter` method is defined in an external macro changelog: [`into_iter_without_iter`]: don't lint if the `IntoIterator` impl is defined in an external macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a hunch this just deadlocked the windows bots. Due to UDP being a lossy
protocol, I don't think we can guarantee that the server can receive both
packets, so just listen for one of them.