Rollup of 9 pull requests

[matthiaskrgr]

Successful merges:

• rustdoc: search for tuples and unit by type with () #118194 (rustdoc: search for tuples and unit by type with ())
• merge core_panic feature into panic_internals #118781 (merge core_panic feature into panic_internals)
• pass allow-{dirty,staged} to clippy #119486 (pass allow-{dirty,staged} to clippy)
• rustc_mir_transform: Make DestinationPropagation stable for queries #119591 (rustc_mir_transform: Make DestinationPropagation stable for queries)
• Fixed ambiguity in hint.rs #119595 (Fixed ambiguity in hint.rs)
• rustc_span: More consistent span combination operations #119624 (rustc_span: More consistent span combination operations)
• compiler: update Fuchsia sanitizer support. #119653 (compiler: update Fuchsia sanitizer support.)
• Remove ignore-stage1 that was added when changing error count msg #119655 (Remove ignore-stage1 that was added when changing error count msg)
• Strip lld-wrapper binaries #119661 (Strip lld-wrapper binaries)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=9

[bors]

📌 Commit 5f0f028 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 5f0f028 with merge b6a8c76...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing b6a8c76 to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#118194	rustdoc: search for tuples and unit by type with ()	516bbf2640c072c931dfcc75c90d3144b6df6531 (link)
#118781	merge core_panic feature into panic_internals	9193d79e6b59aedadc58472c94c143b97968240d (link)
#119486	pass allow-{dirty,staged} to clippy	2d0c651712b744e516975a5fbc6c566996911787 (link)
#119591	rustc_mir_transform: Make DestinationPropagation stable for…	4c76c162b7d5fd97234d1ee5abac601fce2c1f8f (link)
#119595	Fixed ambiguity in hint.rs	fad45fa74ae70de82cda450e913c963a00ac05ce (link)
#119624	rustc_span: More consistent span combination operations	44636caceed80276dcc572665763220a1e5d19c6 (link)
#119653	compiler: update Fuchsia sanitizer support.	9263db4059fc9a4b90e13c2a2667ad27912871cc (link)
#119655	Remove ignore-stage1 that was added when changing error cou…	44a31735c41852f7fcf5643f167ef87c20e5bbfb (link)
#119661	Strip lld-wrapper binaries	5b5b6e955eb59500bb9162cd4336a3533b73edc2 (link)

previous master: 9212108a9b

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (b6a8c76): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	0.7%	[0.2%, 1.3%]	13
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.2%]	6
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.4%, 0.2%]	7

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.4%	[3.4%, 3.4%]	1
Improvements ✅ (primary)	-2.2%	[-2.9%, -1.5%]	2
Improvements ✅ (secondary)	-5.8%	[-9.8%, -1.8%]	2
All ❌✅ (primary)	-2.2%	[-2.9%, -1.5%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.7%	[-1.7%, -1.7%]	1
Improvements ✅ (secondary)	-6.8%	[-6.8%, -6.8%]	1
All ❌✅ (primary)	-1.7%	[-1.7%, -1.7%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.835s -> 668.367s (-0.07%)
Artifact size: 308.53 MiB -> 308.49 MiB (-0.01%)

[Kobzol]

@rust-timer build 44636ca

This looks suspicious w.r.t. the tt-muncher regression.

[rust-timer]

Finished benchmarking commit (44636ca): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	0.7%	[0.2%, 1.3%]	12
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.4%, 0.2%]	5

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.3%, -0.9%]	3
Improvements ✅ (secondary)	-3.5%	[-4.3%, -2.6%]	2
All ❌✅ (primary)	-1.1%	[-1.3%, -0.9%]	3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.7%	[-1.7%, -1.7%]	1
Improvements ✅ (secondary)	-7.5%	[-7.7%, -7.4%]	2
All ❌✅ (primary)	-1.7%	[-1.7%, -1.7%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 668.835s -> 668.722s (-0.02%)
Artifact size: 308.53 MiB -> 308.52 MiB (-0.00%)

[Mark-Simulacrum]

Regression looks real, not sure much can be done about it. Cachegrind diff

$ ./target/release/collector profile_local cachegrind +9212108a9b32cc381995cf509dd2627123c11a25 --rustc2 +44636caceed80276dcc572665763220a1e5d19c6 --include tt-muncher --profiles Check --scenarios Full
--------------------------------------------------------------------------------
-- File:function summary
--------------------------------------------------------------------------------
  Ir________  file:function

< 31,443,976  ???:
  29,581,300    <rustc_span::span_encoding::Span>::source_callsite
   1,596,570    <rustc_span::span_encoding::Span>::to
   1,572,681    <rustc_expand::mbe::macro_rules::MacroRulesMacroExpander as rustc_expand::base::TTMacroExpander>::expand
    -580,131    <rustc_parse::parser::Parser>::parse_path_inner
    -513,825    <rustc_span::symbol::MacroRulesNormalizedIdent>::new
    -375,501    <rustc_ast_lowering::LoweringContext>::lower_qpath
     341,699    rustc_expand::mbe::transcribe::lockstep_iter_size
    -274,767    <rustc_parse::parser::Parser>::parse_expr_path_start
     163,816    <rustc_middle::ty::context::CtxtInterners>::intern_predicate
      85,008    <rustc_middle::ty::context::CtxtInterners>::intern_ty
     -58,408    <rustc_resolve::Resolver as rustc_expand::base::ResolverExpand>::resolve_macro_invocation
     -58,263    <rustc_parse::parser::Parser>::parse_expr_dot_or_call
     -36,353    <hashbrown::raw::inner::RawTable<usize>>::reserve_rehash::<indexmap::map::core::get_hash<rustc_span::SpanData, ()>::{closure#0}>
<   -583,508  ./string/../sysdeps/x86_64/multiarch/memmove-vec-unaligned-erms.S:__memcpy_avx_unaligned_erms
<    -92,944  <all-jemalloc-files>:<all-jemalloc-functions>

cc @petrochenkov -- did you expect a regression from #119624? It sounds like it's supposed to be mostly a refactoring, so maybe missing some extra conditions or wants a fast path?

My inclination is to mark as triaged if we don't see obvious fixes.