Add Ipv6Addr::is_ipv4_mapped #119081
Add Ipv6Addr::is_ipv4_mapped #119081
Conversation
This change consists of cherry-picking the content from the original PR[1], which got closed due to inactivity, and applying the following changes: * Resolving merge conflicts (obviously) * Linked to to_ipv4_mapped instead of to_ipv4 in the documentation (seems more appropriate) * Added the must_use and rustc_const_unstable attributes the original didn't have I think it's a reasonably useful method. [1] rust-lang#86490
|
r? @thomcc (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
I would put this under its own feature gate and tracking issue specifically so it doesn't get grouped into #27709, which has a lot of unknowns still (see #66584 and #76098). This is a lot more straightforward. The referenced PR predates the ACP process so would you mind creating an ACP and linking it here? This is just an issue template at the libs team repo https://github.com/rust-lang/libs-team, it should be accepted pretty easily. @rustbot label -T-libs +T-libs-api +S-waiting-on-ACP |
rustbot
added
S-waiting-on-ACP
rustbot
added
S-waiting-on-author
There was a problem hiding this comment.
Thank you! This looks good to me. I am comfortable accepting this unstable addition — this is straightforward enough that I don't think an ACP would be needed to justify it.
Using #27709 for the tracking issue is fine. I have added Ipv6::is_ipv4_mapped to the method list there. We can (and have in the past) pick out a subset of methods from that tracking issue to stabilize faster, so grouping it together with less promising methods doesn't concern me.
dtolnay
removed
the
S-waiting-on-ACP
|
@bors r+ |
bors
added
S-waiting-on-bors
Rollup of 8 pull requests Successful merges: - rust-lang#116090 (Implement strict integer operations that panic on overflow) - rust-lang#118811 (Use `bool` instead of `PartiolOrd` as return value of the comparison closure in `{slice,Iteraotr}::is_sorted_by`) - rust-lang#119081 (Add Ipv6Addr::is_ipv4_mapped) - rust-lang#119461 (Use an interpreter in MIR jump threading) - rust-lang#119996 (Move OS String implementation into `sys`) - rust-lang#120015 (coverage: Format all coverage tests with `rustfmt`) - rust-lang#120027 (pattern_analysis: Remove `Ty: Copy` bound) - rust-lang#120084 (fix(rust-analyzer): use new pkgid spec to compare) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#119081 - jstasiak:is-ipv4-mapped, r=dtolnay Add Ipv6Addr::is_ipv4_mapped This change consists of cherry-picking the content from the original PR[1], which got closed due to inactivity, and applying the following changes: * Resolving merge conflicts (obviously) * Linked to to_ipv4_mapped instead of to_ipv4 in the documentation (seems more appropriate) * Added the must_use and rustc_const_unstable attributes the original didn't have I think it's a reasonably useful method to have. [1] rust-lang#86490
|
Thank you both, appreciate it. |
This change consists of cherry-picking the content from the original PR[1], which got closed due to inactivity, and applying the following changes:
I think it's a reasonably useful method to have.
[1] #86490