don't fold ParamEnv in register_predicate_obligation

[aliemjay]

>5% perf gain for diesel!

[rustbot]

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

[aliemjay]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 72033c9 with merge 7795ca9...

[compiler-errors]

Interesting. Can you add a debug assertion:

debug_assert_eq!(param_env, resolve_vars_if_possible(param_env));

I don't think it matters anyways, but good to make sure we are aware of subtle things like this I guess.

r=me after perf comes back green.

[bors]

☀️ Try build successful - checks-actions
Build commit: 7795ca9 (7795ca90b2c60a30212abbff4586fb19081e2c3d)

[rust-timer]

Finished benchmarking commit (7795ca9): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-7.3%, -0.2%]	21
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	2
All ❌✅ (primary)	-2.3%	[-7.3%, -0.2%]	21

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.3%	[2.7%, 3.6%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.6%	[-3.5%, -0.8%]	7
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-2.6%	[-3.5%, -0.8%]	7

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.366s -> 671.817s (0.07%)
Artifact size: 312.39 MiB -> 312.47 MiB (0.03%)

[aliemjay]

@bors r=compiler-errors rollup=never

[bors]

📌 Commit e0df93b has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit e0df93b with merge 4283aea...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 4283aea to master...

[rust-timer]

Finished benchmarking commit (4283aea): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Warning ⚠: The following benchmark(s) failed to build:

• libc-0.2.124

cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.1%	[-7.3%, -0.2%]	23
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	-2.1%	[-7.3%, -0.2%]	23

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[1.0%, 1.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.0%	[1.0%, 1.0%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.7%	[-3.3%, -2.4%]	6
Improvements ✅ (secondary)	-3.0%	[-3.6%, -2.4%]	2
All ❌✅ (primary)	-2.7%	[-3.3%, -2.4%]	6

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.948s -> 673.791s (0.13%)
Artifact size: 312.38 MiB -> 312.46 MiB (0.02%)