Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove an unneeded allocation #118981

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Remove an unneeded allocation #118981

merged 1 commit into from
Dec 16, 2023

Conversation

krtab
Copy link
Contributor

@krtab krtab commented Dec 15, 2023

This removes an unneeded allocation in <&[hir::GenericParam<'_>] as NextTypeParamName>::next_type_param_name

@rustbot
Copy link
Collaborator

rustbot commented Dec 15, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 15, 2023
@GuillaumeGomez
Copy link
Member

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 15, 2023
@bors
Copy link
Contributor

bors commented Dec 15, 2023

⌛ Trying commit 8142e85 with merge 684c0e5...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2023
@bors
Auto merge of rust-lang#118981 - krtab:onelessalloc, r=<try>
684c0e5 
Remove an unneeded allocation

This removes an unneeded allocation in `<&[hir::GenericParam<'_>] as NextTypeParamName>::next_type_param_name`
@compiler-errors
Copy link
Member

For the record, this is diagnostics code. This doesn't need a perf run.

@GuillaumeGomez
Copy link
Member

@bors try-

@GuillaumeGomez
Copy link
Member

True.

@compiler-errors
Copy link
Member

You cannot stop a try-build once it's started. r=me after it's done.

@bors
Copy link
Contributor

bors commented Dec 15, 2023

☀️ Try build successful - checks-actions
Build commit: 684c0e5 (684c0e5d105db524c0b6888e3a409a4672711c65)

@rust-timer

This comment has been minimized.

Sign in to view
@compiler-errors
Copy link
Member

@bors r+ rollup=maybe

@bors
Copy link
Contributor

bors commented Dec 15, 2023

📌 Commit 8142e85 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (684c0e5): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)		 -4.3% [-4.3%, -4.3%] 1
All ❌✅ (primary) -0.0% [-0.4%, 0.4%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.8% [-1.0%, -0.6%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.4% [-1.0%, 0.4%] 3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.047s -> 672.214s (0.17%)
Artifact size: 312.39 MiB -> 312.37 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 15, 2023
@workingjubilee
Copy link
Member

@bors rollup=maybe

@workingjubilee workingjubilee mentioned this pull request Dec 15, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2023
@bors
Auto merge of rust-lang#119002 - workingjubilee:rollup-dbfet7s, r=wor…
ca5c68a 
…kingjubilee

Rollup of 5 pull requests

Successful merges:

 - rust-lang#118396 (Collect lang items from AST, get rid of `GenericBound::LangItemTrait`)
 - rust-lang#118727 (Don't pass lint back out of lint decorator)
 - rust-lang#118956 (Make CStr documentation consistent ("nul" instead of "null"))
 - rust-lang#118981 (Remove an unneeded allocation)
 - rust-lang#118998 (Link to is_benchmark from the Ipv6Addr::is_global documentation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3d94fc9 into rust-lang:master Dec 16, 2023
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 16, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 16, 2023
@rust-timer
Unrolled build for rust-lang#118981
883fbd7 
Rollup merge of rust-lang#118981 - krtab:onelessalloc, r=compiler-errors

Remove an unneeded allocation

This removes an unneeded allocation in `<&[hir::GenericParam<'_>] as NextTypeParamName>::next_type_param_name`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
7 participants
@krtab @rustbot @GuillaumeGomez @rust-timer @bors @compiler-errors @workingjubilee