Set the in-rust-tree feature for all rust-analyzer{-proc-macro-srv} steps

[Veykril]

Some context: This came up in https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer/topic/libraryfying.20match.20checking.3F where test and check behaved differently for rust-analyzer
r? @onur-ozkan

[rustbot]

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

[Veykril]

I changed these prefixed ones given we didn't prefix the sysroot-abi feature either in the other places, and I was kind of confused that these worked in the first place

[onur-ozkan]

I guess you missed this part

rust/src/bootstrap/src/core/build_steps/tool.rs

Line 650 in 8c2c233

extra_features: vec!["rust-analyzer/in-rust-tree".to_owned()],

[nnethercote]

I tested and it fixes my original problem, thanks!

[Veykril]

@rustbot ready

[onur-ozkan]

@bors r+

[bors]

📌 Commit e623cc1 has been approved by onur-ozkan

It is now in the queue for this repository.

[bors]

⌛ Testing commit e623cc1 with merge c365c95...

[bors]

💔 Test failed - checks-actions

[Veykril]

I don't understand the issue here 😕

[bjorn3]

rust-analyzer-proc-macro-srv is marked as ToolStd and thus assumed to not depend on the compiler libraries. Try changing it to ToolRustc.

[onur-ozkan]

@bors r+

[bors]

📌 Commit 8aa9c48 has been approved by onur-ozkan

It is now in the queue for this repository.

[Veykril]

Made a mistake when resolving a conflict while rebasing earlier

[onur-ozkan]

@bors r+

[bors]

📌 Commit abf0822 has been approved by onur-ozkan

It is now in the queue for this repository.

[bors]

⌛ Testing commit abf0822 with merge 12f1474...

[rust-log-analyzer]

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling rustc_builtin_macros v0.0.0 (/checkout/compiler/rustc_builtin_macros)
[RUSTC-TIMING] rustc_ast_passes test:false 7.142
[RUSTC-TIMING] rustc_expand test:false 19.825
[RUSTC-TIMING] rustc_builtin_macros test:false 19.461
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
##[group]Clock drift check
  local time: Fri Jan  5 00:02:08 UTC 2024
  network time: Fri, 05 Jan 2024 00:02:08 GMT
##[endgroup]
##[endgroup]
Session terminated, killing shell... ...killed.
##[error]The operation was canceled.

[bors]

💔 Test failed - checks-actions

[lnicola]

@bors retry runner quit

[bors]

⌛ Testing commit abf0822 with merge a59a980...

[bors]

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing a59a980 to master...

[bors]

☀️ Test successful - checks-actions
Approved by: onur-ozkan
Pushing a59a980 to master...

[rust-timer]

Finished benchmarking commit (a59a980): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.5%	[5.5%, 5.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.5%	[-4.5%, -4.5%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.247s -> 670.544s (0.19%)
Artifact size: 311.06 MiB -> 311.06 MiB (0.00%)