Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 6 pull requests #118831

Closed
wants to merge 15 commits into from
Closed

Rollup of 6 pull requests #118831

wants to merge 15 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

tmiasko and others added 15 commits December 10, 2023 10:47
@tmiasko
End locals' live range before suspending coroutine
59188cb 
State transforms retains storage statements for locals that are not
stored inside a coroutine. It ensures those locals are live when
resuming by inserting StorageLive as appropriate. It forgot to end the
storage of those locals when suspending, which is fixed here.

While the end of live range is implicit when executing return, it is
nevertheless useful for inliner which would otherwise extend the live
range beyond return.
@tmiasko
Remove redundant special case for resume argument
6c60abf 
The special case is subsumed by the check for always live locals that
follows it.
@krasimirgg
llvm-wrapper: adapt for LLVM API change
a0c5079 
LLVM commit llvm/llvm-project@1d608fc
renamed the pass.
@onur-ozkan
Dump command invocations from bootstrap shims
f2feed1 
When making changes to the bootstrap that shouldn't change its behavior,
this feature will help developers perform comparisons to check whether the
bootstrap behavior has changed or not.

This can also be used for different purposes. For example, allowing CI to
dump the shims and upload them so that developers can download them and compare
with their local dump to see if CI affects the bootstrap unexpectedly. Or, make CI
perform comparisons on specific bootstrap tests to check for behavior changes between
the master and PR branches.

Signed-off-by: onur-ozkan <[email protected]>
@onur-ozkan
update auto completions
9eeb265 
Signed-off-by: onur-ozkan <[email protected]>
@onur-ozkan
sort dump files at the end of bootstrap
2de3cf8 
To ensure deterministic results we must sort the dump lines.
This is necessary because the order of rustc invocations different
almost all the time.

Signed-off-by: onur-ozkan <[email protected]>
@davidtwco
tests: add sanity-check assembly test for every target
6c993e4 
Adds a basic assembly test checking that each target can produce assembly
and update the target tier policy to require this.

Signed-off-by: David Wood <[email protected]>
@Noratrieb
Edit target doc template to remove email
072cf5f 
We don't really want to communicate with target maintainers via email.
GitHub is where everything happens, people should have a GitHub account
that can be pinged on issues.

This doesn't necessarily have to be a strict rule, but edit the template
to suggest this. The previous template made it look like we care about
having an email address, which we do not.
@Noratrieb
Update table for linker-plugin-lto docs
d94e3e3
@matthiaskrgr
Rollup merge of rust-lang#118647 - onur-ozkan:bootstrap-shims-dump, r…
69a6867 
…=clubby789

dump bootstrap shims

When making changes to the bootstrap that shouldn't change its behavior, this feature will help developers perform comparisons to check whether the bootstrap behavior has changed or not. As an example, when removing Python from the bootstrap by migrating to Rust, this feature will be super useful for ensuring that the behavior remains unaffected. It will assist me in performing comparisons to verify that the bootstrap behavior and its outputs remains consistent throughout the migration process.

This can also be used for different purposes. For example, allowing CI to dump the shims and upload them so that developers can download them and compare with their local dump to see if CI affects the bootstrap unexpectedly. Or, make CI perform comparisons on specific bootstrap tests to check for behavior changes between the master and PR branches.
@matthiaskrgr
Rollup merge of rust-lang#118708 - davidtwco:target-tier-assembly-tes…
6b4a947 
…t, r=Mark-Simulacrum

tests: add sanity-check assembly test for every target

Adds a basic assembly test checking that each target can produce assembly and update the target tier policy to require this.

cc rust-lang/compiler-team#655
r? `@wesleywiser`
@matthiaskrgr
Rollup merge of rust-lang#118797 - tmiasko:dead-coro, r=davidtwco
9137927 
End locals' live range before suspending coroutine

State transforms retains storage statements for locals that are not
stored inside a coroutine. It ensures those locals are live when
resuming by inserting StorageLive as appropriate. It forgot to end the
storage of those locals when suspending, which is fixed here.

While the end of live range is implicit when executing return, it is
nevertheless useful for inliner which would otherwise extend the live
range beyond return.

Fixes rust-lang#117733
@matthiaskrgr
Rollup merge of rust-lang#118818 - krasimirgg:llvm-18-pass, r=nikic
da4432f 
llvm-wrapper: adapt for LLVM API change

LLVM commit llvm/llvm-project@1d608fc renamed the pass.

r? `@nikic`
@matthiaskrgr
Rollup merge of rust-lang#118826 - Nilstrieb:no-email-pls, r=davidtwco
73f72d3 
Edit target doc template to remove email

We don't really want to communicate with target maintainers via email. GitHub is where everything happens, people should have a GitHub account that can be pinged on issues.

This doesn't necessarily have to be a strict rule, but edit the template to suggest this. The previous template made it look like we care about having an email address, which we do not.

r? `@davidtwco`
@matthiaskrgr
Rollup merge of rust-lang#118827 - Nilstrieb:linker-plugin-lto, r=ehuss
ebb8e42 
Update table for linker-plugin-lto docs
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Dec 11, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=6

@bors
Copy link
Contributor

bors commented Dec 11, 2023

📌 Commit ebb8e42 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2023
@bors
Copy link
Contributor

bors commented Dec 11, 2023

⌛ Testing commit ebb8e42 with merge 8b4db9c...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 11, 2023
@bors
Auto merge of rust-lang#118831 - matthiaskrgr:rollup-banu9rm, r=matth…
8b4db9c 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#118647 (dump bootstrap shims)
 - rust-lang#118708 (tests: add sanity-check assembly test for every target)
 - rust-lang#118797 (End locals' live range before suspending coroutine)
 - rust-lang#118818 (llvm-wrapper: adapt for LLVM API change)
 - rust-lang#118826 (Edit target doc template to remove email)
 - rust-lang#118827 (Update table for linker-plugin-lto docs)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The job test-various failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
failures:

---- [mir-opt] tests/mir-opt/inline/inline_coroutine.rs stdout ----
89 + 
90 +     bb6: {
91 +         _1 = CoroutineState::<i32, bool>::Yielded(move _8);
+ +         StorageDead(_8);
92 +         discriminant((*_6)) = 3;
93 +         goto -> bb2;

thread '[mir-opt] tests/mir-opt/inline/inline_coroutine.rs' panicked at src/tools/compiletest/src/runtest.rs:4103:21:
Actual MIR output differs from expected MIR output /checkout/tests/mir-opt/inline/inline_coroutine.main.Inline.panic-abort.diff
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@bors
Copy link
Contributor

bors commented Dec 11, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 11, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 11, 2023
Merged
@matthiaskrgr matthiaskrgr deleted the rollup-banu9rm branch March 16, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@matthiaskrgr @bors @rust-log-analyzer @rustbot @tmiasko @krasimirgg @onur-ozkan @davidtwco @Noratrieb