extra: move arena and glob to libarena and libglob #11867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -537,7 +542,7 @@ impl MatchOptions { | |||
| #[cfg(test)] | |||
| mod test { | |||
| use std::os; | |||
| use super::*; | |||
| //use super::{inflate_bytes, deflate_bytes}; | |||
There was a problem hiding this comment.
You can probably remove this line.
|
This is pretty awesome, nice work! It's a little sad that |
| /doc/green | ||
| /doc/native | ||
| /doc/rustc | ||
| /doc/syntax | ||
| /doc/rustuv | ||
| /doc/rustpkg | ||
|
|
There was a problem hiding this comment.
I'll fix that - bloody default text editor behaviour
In line with the dissolution of libextra - rust-lang#8784 - moves arena to its own library libarena. Changes based on PR rust-lang#11787. Updates .gitignore to ignore doc/arena.
In line with the dissolution of libextra - moves glob to its own library libglob. Changes based on PR rust-lang#11787. Updates .gitignore to ignore doc/glob.
Merged
|
I think this may need #11903 to go in first to fix the android tests (just a guess though). |
|
It's worth noting that i had failed to notice that "glob" was actually missing from TARGET_CRATES in mk/crates.mk when the test failed - I fixed that in the new commit (93398d1), but I'm unclear whether the test failure will remain. |
|
Hm interesting. My guess is that it will build cleanly, but it will fail to run on android. Oh well, I'll let bors figure out what will actually happen! |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 29, 2014
This changes android testing to upload *all* target crates rather than just a select subset. This should unblock rust-lang#11867 which is introducing a libglob dependency in testing.
bors
added a commit
that referenced
this pull request
Jan 29, 2014
This changes android testing to upload *all* target crates rather than just a select subset. This should unblock #11867 which is introducing a libglob dependency in testing.
bors
added a commit
that referenced
this pull request
Jan 29, 2014
In line with the dissolution of libextra - #8784 - this moves arena and glob into their own respective modules. Updates .gitignore with the entries doc/{arena,glob} in accordance.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 1, 2023
…y, r=Jarcho Move `implied_bounds_in_impls` back to complexity This lint was originally in the complexity category when I PR'd it. It was then moved to nursery by me due to a number of issues (a false positive, an invalid suggestion and an ICE), but that was probably an overreaction and all of the issues were fixed quickly after. This is a useful lint imo and there hasn't been any issues with it in a few months, so I say we should give it another try and move it back to complexity. I did a lintcheck run on the top 400 crates and all of them are legitimate, with 18 warnings. Most of them are from anstyle having a `impl Display + Copy + Clone` return type, or the bitvec crate with a return type like `impl Iterator + DoubleEndedIterator`. changelog: Move [`implied_bounds_in_impls`] to `complexity` (Now warn-by-default) [rust-lang#11867](rust-lang/rust-clippy#11867)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line with the dissolution of libextra - #8784 - this moves arena and glob into
their own respective modules. Updates .gitignore with the entries
doc/{arena,glob} in accordance.