-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new solver: improve instrument annotations #118454
Conversation
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
@bors r+ |
@bors rollup |
new solver: improve instrument annotations
💔 Test failed - checks-actions |
let's test again @bors p=101 |
new solver: improve instrument annotations
@bors retry |
Oh damn sorry. I saw the log-analyzer message and thought it meant the run had failed. But that message was heavily delayed, this was an error from the run before... |
Nah, it was worth checking again. Keeping the tree closed in that case :3 |
Yeah I just canceled and restarted a perfectly good run though. (Look just at the bors messages and ignore the log-analyzer. log-analyzer sometimes has large latency leading to confusing interleaving of messages.) Oh well, too late to do anything about it. |
Ohhh I get it. Oh well 🤷 😄 |
looks like tree can be opened @bors treeclosed- |
@bors ping |
😪 I'm awake I'm awake |
☀️ Test successful - checks-actions |
Finished benchmarking commit (475f6f8): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 673.247s -> 675.01s (0.26%) |
No description provided.