Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo #118101

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Update cargo #118101

merged 1 commit into from
Nov 20, 2023

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Nov 20, 2023

9 commits in 9765a449d9b7341c2b49b88da41c2268ea599720..71cd3a926f0cf41eeaf9f2a7f2194b2aff85b0f6
2023-11-17 20:58:23 +0000 to 2023-11-20 15:30:57 +0000

@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2023

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 20, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2023

Some changes occurred in src/tools/cargo

cc @ehuss

@dtolnay
Copy link
Member Author

dtolnay commented Nov 20, 2023

The reason for the off-schedule update is to pull in rust-lang/cargo#13016 to unblock #115691.

@weihanglo
Copy link
Member

No problem. Looks good to me. Thank you :)

@bors r+ p=1 rollup=never

@bors
Copy link
Contributor

bors commented Nov 20, 2023

📌 Commit 63171a7 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2023
@bors
Copy link
Contributor

bors commented Nov 20, 2023

⌛ Testing commit 63171a7 with merge 3a85a5c...

@bors
Copy link
Contributor

bors commented Nov 20, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 3a85a5c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 20, 2023
@bors bors merged commit 3a85a5c into rust-lang:master Nov 20, 2023
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Nov 20, 2023
@dtolnay dtolnay deleted the cargo branch November 20, 2023 23:52
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3a85a5c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.0% [-1.0%, -1.0%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.0% [-1.0%, -1.0%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.8% [4.8%, 4.8%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.2% [-3.2%, -3.2%] 1
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.6% [-1.6%, -1.6%] 1
Improvements ✅
(secondary)
-2.4% [-2.8%, -2.1%] 3
All ❌✅ (primary) -1.6% [-1.6%, -1.6%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 677.019s -> 677.57s (0.08%)
Artifact size: 313.78 MiB -> 313.75 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants