Skip to content

intercrate_ambiguity_causes: handle self ty infer + reservation impls #118089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2023
Merged

intercrate_ambiguity_causes: handle self ty infer + reservation impls #118089

merged 2 commits into from
Nov 21, 2023

Conversation

@lcnr
Copy link
Contributor

@lcnr lcnr commented Nov 20, 2023

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Nov 20, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2023

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@lcnr lcnr force-pushed the intercrate-ambig-msg branch from aaa58c7 to 35c8a37 Compare November 20, 2023 14:01
@lcnr lcnr changed the title self ty infer ambiguity: add proof tree cand intercrate_ambiguity_causes: handle self ty infer + reservation impls Nov 20, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2023

Could not assign reviewer from: compiler-errors.
User(s) compiler-errors are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 20, 2023

📌 Commit 35c8a37 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 20, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2023
@bors
Auto merge of rust-lang#118107 - matthiaskrgr:rollup-k5bfkfr, r=matth…
b8e8b47 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#117327 (Add documentation for some queries)
 - rust-lang#117835 (Note about object lifetime defaults in does not live long enough error)
 - rust-lang#117851 (Uplift `InferConst` to `rustc_type_ir`)
 - rust-lang#117973 (test: Add test for async-move in 2015 Rust proc macro)
 - rust-lang#117992 (Don't require intercrate mode for negative coherence)
 - rust-lang#118010 (Typeck break expr even if break is illegal)
 - rust-lang#118026 (Don't consider regions in `deref_into_dyn_supertrait` lint)
 - rust-lang#118089 (intercrate_ambiguity_causes: handle self ty infer + reservation impls)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2023
@bors
Auto merge of rust-lang#118107 - matthiaskrgr:rollup-k5bfkfr, r=matth…
549c0b9 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#117327 (Add documentation for some queries)
 - rust-lang#117835 (Note about object lifetime defaults in does not live long enough error)
 - rust-lang#117851 (Uplift `InferConst` to `rustc_type_ir`)
 - rust-lang#117973 (test: Add test for async-move in 2015 Rust proc macro)
 - rust-lang#117992 (Don't require intercrate mode for negative coherence)
 - rust-lang#118010 (Typeck break expr even if break is illegal)
 - rust-lang#118026 (Don't consider regions in `deref_into_dyn_supertrait` lint)
 - rust-lang#118089 (intercrate_ambiguity_causes: handle self ty infer + reservation impls)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2023
@bors
Auto merge of rust-lang#118107 - matthiaskrgr:rollup-k5bfkfr, r=matth…
baf4abf 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#117327 (Add documentation for some queries)
 - rust-lang#117835 (Note about object lifetime defaults in does not live long enough error)
 - rust-lang#117851 (Uplift `InferConst` to `rustc_type_ir`)
 - rust-lang#117973 (test: Add test for async-move in 2015 Rust proc macro)
 - rust-lang#117992 (Don't require intercrate mode for negative coherence)
 - rust-lang#118010 (Typeck break expr even if break is illegal)
 - rust-lang#118026 (Don't consider regions in `deref_into_dyn_supertrait` lint)
 - rust-lang#118089 (intercrate_ambiguity_causes: handle self ty infer + reservation impls)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2023
@rust-timer
Unrolled build for rust-lang#118089
b4cc3a0 
Rollup merge of rust-lang#118089 - lcnr:intercrate-ambig-msg, r=compiler-errors

intercrate_ambiguity_causes: handle self ty infer + reservation impls

r? `@compiler-errors`
@bors bors merged commit 6c62b42 into rust-lang:master Nov 21, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 21, 2023
@lcnr lcnr deleted the intercrate-ambig-msg branch November 21, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@compiler-errors compiler-errors

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.76.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lcnr @rustbot @compiler-errors @bors